Skip to content

Commit fdc9f17

Browse files
committed
feat: allow async in client props
1 parent 826a9fa commit fdc9f17

File tree

7 files changed

+196
-66
lines changed

7 files changed

+196
-66
lines changed

packages/melange.ppx/tests/external.t

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ mel.as attribute
1212
"[server-reason-react.melange_ppx] There's an external in native, which should \
1313
only happen in JavaScript. You need to conditionally run it, either by not \
1414
including it on native or via let%browser_only/switch%platform. More info at \
15-
https://ml-in-barcelona.github.io/server-reason-react/local/server-reason-react/browser_only.html"]
15+
https://ml-in-barcelona.github.io/server-reason-react/server-reason-react/browser_ppx.html"]
1616

1717
$ echo "module Runtime = struct" > main.ml
1818
$ cat $INSIDE_DUNE/packages/runtime/Runtime.ml >> main.ml
@@ -26,5 +26,5 @@ mel.as attribute
2626
should only happen in JavaScript. You need to conditionally run it,
2727
either by not including it on native or via
2828
let%browser_only/switch%platform. More info at
29-
https://ml-in-barcelona.github.io/server-reason-react/local/server-reason-react/browser_only.html
29+
https://ml-in-barcelona.github.io/server-reason-react/server-reason-react/browser_ppx.html
3030
[2]

packages/melange.ppx/tests/mel_module.t

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ Single type (invalid OCaml, but valid in Melange)
6868
\"...\"] in native, which should only happen in JavaScript. You need to \
6969
conditionally run it, either by not including it on native or via \
7070
let%browser_only/switch%platform. More info at \
71-
https://ml-in-barcelona.github.io/server-reason-react/local/server-reason-react/browser_only.html"]
71+
https://ml-in-barcelona.github.io/server-reason-react/server-reason-react/browser_ppx.html"]
7272

7373
$ echo "module Runtime = struct" > main.ml
7474
$ cat $INSIDE_DUNE/packages/runtime/Runtime.ml >> main.ml
@@ -82,7 +82,7 @@ Single type (invalid OCaml, but valid in Melange)
8282
[%mel.module "..."] in native, which should only happen in JavaScript.
8383
You need to conditionally run it, either by not including it on native
8484
or via let%browser_only/switch%platform. More info at
85-
https://ml-in-barcelona.github.io/server-reason-react/local/server-reason-react/browser_only.html
85+
https://ml-in-barcelona.github.io/server-reason-react/server-reason-react/browser_ppx.html
8686
[2]
8787

8888
Assets with file not found

packages/melange.ppx/tests/mel_raw.t

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ mel.raw as a value
1010
{ return element.ownerDocument; } \"] expression in native, which should \
1111
only happen in JavaScript. You need to conditionally run it via \
1212
let%browser_only or switch%platform. More info at \
13-
https://ml-in-barcelona.github.io/server-reason-react/local/server-reason-react/browser_only.html"]
13+
https://ml-in-barcelona.github.io/server-reason-react/server-reason-react/browser_ppx.html"]
1414

1515
mel.raw as an unary function
1616

@@ -24,7 +24,7 @@ mel.raw as an unary function
2424
{ return element.ownerDocument; } \"] expression in native, which should \
2525
only happen in JavaScript. You need to conditionally run it via \
2626
let%browser_only or switch%platform. More info at \
27-
https://ml-in-barcelona.github.io/server-reason-react/local/server-reason-react/browser_only.html"]
27+
https://ml-in-barcelona.github.io/server-reason-react/server-reason-react/browser_ppx.html"]
2828

2929
mel.raw as an binary function
3030

@@ -44,7 +44,7 @@ mel.raw as an binary function
4444
} \"] expression in native, which should only happen in JavaScript. You \
4545
need to conditionally run it via let%browser_only or switch%platform. More \
4646
info at \
47-
https://ml-in-barcelona.github.io/server-reason-react/local/server-reason-react/browser_only.html"]
47+
https://ml-in-barcelona.github.io/server-reason-react/server-reason-react/browser_ppx.html"]
4848

4949
mel.raw with type
5050

@@ -60,7 +60,7 @@ mel.raw with type
6060
"[server-reason-react.melange_ppx] There's a [%mel.raw \"window\"] \
6161
expression in native, which should only happen in JavaScript. You need to \
6262
conditionally run it via let%browser_only or switch%platform. More info at \
63-
https://ml-in-barcelona.github.io/server-reason-react/local/server-reason-react/browser_only.html"]
63+
https://ml-in-barcelona.github.io/server-reason-react/server-reason-react/browser_ppx.html"]
6464

6565
$ echo "module Runtime = struct" > main.ml
6666
$ cat $INSIDE_DUNE/packages/runtime/Runtime.ml >> main.ml
@@ -74,7 +74,7 @@ mel.raw with type
7474
expression in native, which should only happen in JavaScript. You need
7575
to conditionally run it via let%browser_only or switch%platform. More
7676
info at
77-
https://ml-in-barcelona.github.io/server-reason-react/local/server-reason-react/browser_only.html
77+
https://ml-in-barcelona.github.io/server-reason-react/server-reason-react/browser_ppx.html
7878
[2]
7979

8080
mel.raw as a value
@@ -89,4 +89,4 @@ mel.raw as a value
8989
console.log(\"running in JS\"); \"] expression in native, which should only \
9090
happen in JavaScript. You need to conditionally run it via let%browser_only \
9191
or switch%platform. More info at \
92-
https://ml-in-barcelona.github.io/server-reason-react/local/server-reason-react/browser_only.html"]
92+
https://ml-in-barcelona.github.io/server-reason-react/server-reason-react/browser_ppx.html"]

0 commit comments

Comments
 (0)