common base class

mb706 · mb706 · commit faa2e380abdf · 2025-08-13T15:39:45.000+02:00
diff --git a/.lintr b/.lintr
@@ -5,6 +5,7 @@ linters: linters_with_defaults(
     object_name_linter = object_name_linter(c("snake_case", "CamelCase")), # only allow snake case and camel case object names
     cyclocomp_linter = NULL, # do not check function complexity
     commented_code_linter = NULL, # allow code in comments
-    line_length_linter = line_length_linter(120)
+    line_length_linter = line_length_linter(120),
+    indentation_linter = indentation_linter(indent = 2, hanging_indent_style = "never")
     )
 
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -26,6 +26,9 @@ Depends:
     R (>= 3.1.0)
 Suggests:
     mlr3 (>= 0.13.3)
+Remotes:
+    mlr-org/mlr3misc@common_baseclass,
+    mlr-org/mlr3@common_baseclass
 Encoding: UTF-8
 LazyData: true
 LazyDataCompression: xz
diff --git a/R/ames_housing.R b/R/ames_housing.R
@@ -18,7 +18,7 @@ NULL
 
 get_ames_housing_task = function() {
   b = as_backend("ames_housing")
-  task = mlr3::TaskRegr$new("ames_housing", b, target = "Sale_Price", label = "Ames House Sales")
-  b$hash = task$man = "mlr3data::mlr_tasks_ames_housing"
+  task = mlr3::TaskRegr$new("ames_housing", b, target = "Sale_Price")
+  task$override_info(man = "mlr3data::mlr_tasks_ames_housing", hash = "mlr3data::mlr_tasks_ames_housing")
   task
 }
diff --git a/R/bike_sharing.R b/R/bike_sharing.R
@@ -24,7 +24,7 @@ NULL
 
 get_bike_sharing_task = function() {
   b = as_backend("bike_sharing")
-  task = mlr3::TaskRegr$new("bike_sharing", b, target = "count", label = "Bike Sharing Demand")
-  b$hash = task$man = "mlr3data::mlr_tasks_bike_sharing"
+  task = mlr3::TaskRegr$new("bike_sharing", b, target = "count")
+  task$override_info(man = "mlr3data::mlr_tasks_bike_sharing", hash = "mlr3data::mlr_tasks_bike_sharing")
   task
 }
diff --git a/R/ilpd.R b/R/ilpd.R
@@ -23,7 +23,7 @@ NULL
 
 get_ilpd_task = function() {
   b = as_backend("ilpd")
-  task = mlr3::TaskClassif$new("ilpd", b, target = "diseased", positive = "yes", label = "Indian Liver Patient Data")
-  b$hash = task$man = "mlr3data::mlr_tasks_ilpd"
+  task = mlr3::TaskClassif$new("ilpd", b, target = "diseased", positive = "yes")
+  task$override_info(man = "mlr3data::mlr_tasks_ilpd", hash = "mlr3data::mlr_tasks_ilpd")
   task
 }
diff --git a/R/kc_housing.R b/R/kc_housing.R
@@ -28,7 +28,7 @@ NULL
 
 get_kc_housing_task = function() {
   b = as_backend("kc_housing")
-  task = mlr3::TaskRegr$new("kc_housing", b, target = "price", label = "King County House Sales")
-  b$hash = task$man = "mlr3data::mlr_tasks_kc_housing"
+  task = mlr3::TaskRegr$new("kc_housing", b, target = "price")
+  task$override_info(man = "mlr3data::mlr_tasks_kc_housing", hash = "mlr3data::mlr_tasks_kc_housing")
   task
 }
diff --git a/R/moneyball.R b/R/moneyball.R
@@ -25,7 +25,7 @@ NULL
 
 get_moneyball_task = function() {
   b = as_backend("moneyball")
-  task = mlr3::TaskRegr$new("moneyball", b, target = "rs", label = "Major League Baseball Statistics")
-  b$hash = task$man = "mlr3data::mlr_tasks_moneyball"
+  task = mlr3::TaskRegr$new("moneyball", b, target = "rs")
+  task$override_info(man = "mlr3data::mlr_tasks_moneyball", hash = "mlr3data::mlr_tasks_moneyball")
   task
 }
diff --git a/R/optdigits.R b/R/optdigits.R
@@ -30,8 +30,7 @@ NULL
 
 get_optdigits_task = function() {
   b = as_backend("optdigits")
-  task = mlr3::TaskClassif$new("optdigits", b, target = "binaryclass", positive = "P",
-    label = "Optical Recognition of Handwritten Digits")
-  b$hash = task$man = "mlr3data::mlr_tasks_optdigits"
+  task = mlr3::TaskClassif$new("optdigits", b, target = "binaryclass", positive = "P")
+  task$override_info(man = "mlr3data::mlr_tasks_optdigits", hash = "mlr3data::mlr_tasks_optdigits")
   task
 }
diff --git a/R/penguins_simple.R b/R/penguins_simple.R
@@ -29,7 +29,7 @@ NULL
 
 get_penguins_simple_task = function() {
   b = as_backend("penguins_simple")
-  task = mlr3::TaskClassif$new("penguins", b, target = "species", label = "Simplified Palmer Penguins")
-  b$hash = task$man = "mlr3data::mlr_tasks_penguins_simple"
+  task = mlr3::TaskClassif$new("penguins", b, target = "species")
+  task$override_info(man = "mlr3data::mlr_tasks_penguins_simple", hash = "mlr3data::mlr_tasks_penguins_simple")
   task
 }
diff --git a/R/titanic.R b/R/titanic.R
@@ -28,7 +28,7 @@ NULL
 
 get_titanic_task = function() {
   b = as_backend("titanic")
-  task = mlr3::TaskClassif$new("titanic", b, target = "survived", positive = "yes", label = "Titanic")
-  b$hash = task$man = "mlr3data::mlr_tasks_titanic"
+  task = mlr3::TaskClassif$new("titanic", b, target = "survived", positive = "yes")
+  task$override_info(man = "mlr3data::mlr_tasks_titanic", hash = "mlr3data::mlr_tasks_titanic")
   task
 }
diff --git a/tests/test_data_sets.R b/tests/test_data_sets.R
@@ -28,8 +28,17 @@ stopifnot(nrow(moneyball) == 1232L, ncol(moneyball) == 15L)
 
 
 if (requireNamespace("mlr3")) {
+  old_opts = options(
+    warnPartialMatchArgs = TRUE,
+    warnPartialMatchAttr = TRUE,
+    warnPartialMatchDollar = TRUE,
+    mlr3.on_deprecated = "error"
+  )
+
   stopifnot(inherits(mlr3::tsk("kc_housing"), "TaskRegr"))
   stopifnot(inherits(mlr3::tsk("titanic"), "TaskClassif"))
   stopifnot(inherits(mlr3::tsk("optdigits"), "TaskClassif"))
   stopifnot(inherits(mlr3::tsk("moneyball"), "TaskRegr"))
+
+  options(old_opts)
 }

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@ linters: linters_with_defaults(`
`5`	`5`	`object_name_linter = object_name_linter(c("snake_case", "CamelCase")), # only allow snake case and camel case object names`
`6`	`6`	`cyclocomp_linter = NULL, # do not check function complexity`
`7`	`7`	`commented_code_linter = NULL, # allow code in comments`
`8`		`- line_length_linter = line_length_linter(120)`
	`8`	`+ line_length_linter = line_length_linter(120),`
	`9`	`+ indentation_linter = indentation_linter(indent = 2, hanging_indent_style = "never")`
`9`	`10`	`)`
`10`	`11`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ NULL`
`18`	`18`
`19`	`19`	`get_ames_housing_task = function() {`
`20`	`20`	`b = as_backend("ames_housing")`
`21`		`- task = mlr3::TaskRegr$new("ames_housing", b, target = "Sale_Price", label = "Ames House Sales")`
`22`		`- b$hash = task$man = "mlr3data::mlr_tasks_ames_housing"`
	`21`	`+ task = mlr3::TaskRegr$new("ames_housing", b, target = "Sale_Price")`
	`22`	`+ task$override_info(man = "mlr3data::mlr_tasks_ames_housing", hash = "mlr3data::mlr_tasks_ames_housing")`
`23`	`23`	`task`
`24`	`24`	`}`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ NULL`
`24`	`24`
`25`	`25`	`get_bike_sharing_task = function() {`
`26`	`26`	`b = as_backend("bike_sharing")`
`27`		`- task = mlr3::TaskRegr$new("bike_sharing", b, target = "count", label = "Bike Sharing Demand")`
`28`		`- b$hash = task$man = "mlr3data::mlr_tasks_bike_sharing"`
	`27`	`+ task = mlr3::TaskRegr$new("bike_sharing", b, target = "count")`
	`28`	`+ task$override_info(man = "mlr3data::mlr_tasks_bike_sharing", hash = "mlr3data::mlr_tasks_bike_sharing")`
`29`	`29`	`task`
`30`	`30`	`}`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ NULL`
`23`	`23`
`24`	`24`	`get_ilpd_task = function() {`
`25`	`25`	`b = as_backend("ilpd")`
`26`		`- task = mlr3::TaskClassif$new("ilpd", b, target = "diseased", positive = "yes", label = "Indian Liver Patient Data")`
`27`		`- b$hash = task$man = "mlr3data::mlr_tasks_ilpd"`
	`26`	`+ task = mlr3::TaskClassif$new("ilpd", b, target = "diseased", positive = "yes")`
	`27`	`+ task$override_info(man = "mlr3data::mlr_tasks_ilpd", hash = "mlr3data::mlr_tasks_ilpd")`
`28`	`28`	`task`
`29`	`29`	`}`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ NULL`
`28`	`28`
`29`	`29`	`get_kc_housing_task = function() {`
`30`	`30`	`b = as_backend("kc_housing")`
`31`		`- task = mlr3::TaskRegr$new("kc_housing", b, target = "price", label = "King County House Sales")`
`32`		`- b$hash = task$man = "mlr3data::mlr_tasks_kc_housing"`
	`31`	`+ task = mlr3::TaskRegr$new("kc_housing", b, target = "price")`
	`32`	`+ task$override_info(man = "mlr3data::mlr_tasks_kc_housing", hash = "mlr3data::mlr_tasks_kc_housing")`
`33`	`33`	`task`
`34`	`34`	`}`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ NULL`
`25`	`25`
`26`	`26`	`get_moneyball_task = function() {`
`27`	`27`	`b = as_backend("moneyball")`
`28`		`- task = mlr3::TaskRegr$new("moneyball", b, target = "rs", label = "Major League Baseball Statistics")`
`29`		`- b$hash = task$man = "mlr3data::mlr_tasks_moneyball"`
	`28`	`+ task = mlr3::TaskRegr$new("moneyball", b, target = "rs")`
	`29`	`+ task$override_info(man = "mlr3data::mlr_tasks_moneyball", hash = "mlr3data::mlr_tasks_moneyball")`
`30`	`30`	`task`
`31`	`31`	`}`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ NULL`
`29`	`29`
`30`	`30`	`get_penguins_simple_task = function() {`
`31`	`31`	`b = as_backend("penguins_simple")`
`32`		`- task = mlr3::TaskClassif$new("penguins", b, target = "species", label = "Simplified Palmer Penguins")`
`33`		`- b$hash = task$man = "mlr3data::mlr_tasks_penguins_simple"`
	`32`	`+ task = mlr3::TaskClassif$new("penguins", b, target = "species")`
	`33`	`+ task$override_info(man = "mlr3data::mlr_tasks_penguins_simple", hash = "mlr3data::mlr_tasks_penguins_simple")`
`34`	`34`	`task`
`35`	`35`	`}`