From 3e7cbf8e35cb39ba43dbbc13c2ea59df37c34bd5 Mon Sep 17 00:00:00 2001 From: Marc Becker <33069354+be-marc@users.noreply.github.com> Date: Tue, 26 Nov 2024 14:55:28 +0100 Subject: [PATCH] refactor: only pass extra to assign_result (#473) * refactor: only pass extra to assign_result * ... * ... --- R/TuningInstanceAsyncMulticrit.R | 7 +------ R/TuningInstanceAsyncSingleCrit.R | 7 +------ R/TuningInstanceBatchMulticrit.R | 7 +------ R/TuningInstanceBatchSingleCrit.R | 7 +------ man/TuningInstanceAsyncMultiCrit.Rd | 4 ---- man/TuningInstanceAsyncSingleCrit.Rd | 4 ---- man/TuningInstanceBatchMultiCrit.Rd | 4 ---- man/TuningInstanceBatchSingleCrit.Rd | 4 ---- 8 files changed, 4 insertions(+), 40 deletions(-) diff --git a/R/TuningInstanceAsyncMulticrit.R b/R/TuningInstanceAsyncMulticrit.R index 7fae8e8d..f055e65e 100644 --- a/R/TuningInstanceAsyncMulticrit.R +++ b/R/TuningInstanceAsyncMulticrit.R @@ -154,14 +154,9 @@ TuningInstanceAsyncMultiCrit = R6Class("TuningInstanceAsyncMultiCrit", #' #' @param ydt (`numeric(1)`)\cr #' Optimal outcomes, e.g. the Pareto front. - #' @param xydt (`data.table::data.table()`)\cr - #' Point, outcome, and additional information. #' @param ... (`any`)\cr #' ignored. - assign_result = function(xdt, ydt, learner_param_vals = NULL, extra = NULL, xydt = NULL, ...) { - # workaround - extra = extra %??% xydt - + assign_result = function(xdt, ydt, learner_param_vals = NULL, extra = NULL, ...) { # assign for callbacks private$.result_xdt = xdt private$.result_ydt = ydt diff --git a/R/TuningInstanceAsyncSingleCrit.R b/R/TuningInstanceAsyncSingleCrit.R index 8ae52451..74f1f46d 100644 --- a/R/TuningInstanceAsyncSingleCrit.R +++ b/R/TuningInstanceAsyncSingleCrit.R @@ -164,14 +164,9 @@ TuningInstanceAsyncSingleCrit = R6Class("TuningInstanceAsyncSingleCrit", #' #' @param y (`numeric(1)`)\cr #' Optimal outcome. - #' @param xydt (`data.table::data.table()`)\cr - #' Point, outcome, and additional information (Deprecated). #' @param ... (`any`)\cr #' ignored. - assign_result = function(xdt, y, learner_param_vals = NULL, extra = NULL, xydt = NULL, ...) { - # workaround - extra = extra %??% xydt - + assign_result = function(xdt, y, learner_param_vals = NULL, extra = NULL, ...) { # assign for callbacks private$.result_xdt = xdt private$.result_y = y diff --git a/R/TuningInstanceBatchMulticrit.R b/R/TuningInstanceBatchMulticrit.R index f0347153..eb6b2a84 100644 --- a/R/TuningInstanceBatchMulticrit.R +++ b/R/TuningInstanceBatchMulticrit.R @@ -182,14 +182,9 @@ TuningInstanceBatchMultiCrit = R6Class("TuningInstanceBatchMultiCrit", #' #' @param ydt (`data.table::data.table()`)\cr #' Optimal outcomes, e.g. the Pareto front. - #' @param xydt (`data.table::data.table()`)\cr - #' Point, outcome, and additional information (Deprecated). #' @param ... (`any`)\cr #' ignored. - assign_result = function(xdt, ydt, learner_param_vals = NULL, extra = NULL, xydt = NULL, ...) { - # workaround - extra = extra %??% xydt - + assign_result = function(xdt, ydt, learner_param_vals = NULL, extra = NULL, ...) { # assign for callbacks private$.result_xdt = xdt private$.result_ydt = ydt diff --git a/R/TuningInstanceBatchSingleCrit.R b/R/TuningInstanceBatchSingleCrit.R index 5272d0f0..80dd422b 100644 --- a/R/TuningInstanceBatchSingleCrit.R +++ b/R/TuningInstanceBatchSingleCrit.R @@ -232,14 +232,9 @@ TuningInstanceBatchSingleCrit = R6Class("TuningInstanceBatchSingleCrit", #' #' @param y (`numeric(1)`)\cr #' Optimal outcome. - #' @param xydt (`data.table::data.table()`)\cr - #' Point, outcome, and additional information (Deprecated). #' @param ... (`any`)\cr #' ignored. - assign_result = function(xdt, y, learner_param_vals = NULL, extra = NULL, xydt = NULL, ...) { - # workaround - extra = extra %??% xydt - + assign_result = function(xdt, y, learner_param_vals = NULL, extra = NULL, ...) { # assign for callbacks private$.result_xdt = xdt private$.result_y = y diff --git a/man/TuningInstanceAsyncMultiCrit.Rd b/man/TuningInstanceAsyncMultiCrit.Rd index 851e6b1b..2caf366b 100644 --- a/man/TuningInstanceAsyncMultiCrit.Rd +++ b/man/TuningInstanceAsyncMultiCrit.Rd @@ -173,7 +173,6 @@ For internal use. ydt, learner_param_vals = NULL, extra = NULL, - xydt = NULL, ... )}\if{html}{\out{}} } @@ -195,9 +194,6 @@ Fixed parameter values of the learner that are neither part of the} \item{\code{extra}}{(\code{data.table::data.table()})\cr Additional information.} -\item{\code{xydt}}{(\code{data.table::data.table()})\cr -Point, outcome, and additional information.} - \item{\code{...}}{(\code{any})\cr ignored.} } diff --git a/man/TuningInstanceAsyncSingleCrit.Rd b/man/TuningInstanceAsyncSingleCrit.Rd index 66db20e5..d248786a 100644 --- a/man/TuningInstanceAsyncSingleCrit.Rd +++ b/man/TuningInstanceAsyncSingleCrit.Rd @@ -202,7 +202,6 @@ For internal use. y, learner_param_vals = NULL, extra = NULL, - xydt = NULL, ... )}\if{html}{\out{}} } @@ -224,9 +223,6 @@ Fixed parameter values of the learner that are neither part of the} \item{\code{extra}}{(\code{data.table::data.table()})\cr Additional information.} -\item{\code{xydt}}{(\code{data.table::data.table()})\cr -Point, outcome, and additional information (Deprecated).} - \item{\code{...}}{(\code{any})\cr ignored.} } diff --git a/man/TuningInstanceBatchMultiCrit.Rd b/man/TuningInstanceBatchMultiCrit.Rd index 4f8a0571..4571fe10 100644 --- a/man/TuningInstanceBatchMultiCrit.Rd +++ b/man/TuningInstanceBatchMultiCrit.Rd @@ -212,7 +212,6 @@ For internal use. ydt, learner_param_vals = NULL, extra = NULL, - xydt = NULL, ... )}\if{html}{\out{}} } @@ -234,9 +233,6 @@ Fixed parameter values of the learner that are neither part of the} \item{\code{extra}}{(\code{data.table::data.table()})\cr Additional information.} -\item{\code{xydt}}{(\code{data.table::data.table()})\cr -Point, outcome, and additional information (Deprecated).} - \item{\code{...}}{(\code{any})\cr ignored.} } diff --git a/man/TuningInstanceBatchSingleCrit.Rd b/man/TuningInstanceBatchSingleCrit.Rd index 5b7489bf..f3cad63c 100644 --- a/man/TuningInstanceBatchSingleCrit.Rd +++ b/man/TuningInstanceBatchSingleCrit.Rd @@ -238,7 +238,6 @@ For internal use. y, learner_param_vals = NULL, extra = NULL, - xydt = NULL, ... )}\if{html}{\out{}} } @@ -260,9 +259,6 @@ Fixed parameter values of the learner that are neither part of the} \item{\code{extra}}{(\code{data.table::data.table()})\cr Additional information.} -\item{\code{xydt}}{(\code{data.table::data.table()})\cr -Point, outcome, and additional information (Deprecated).} - \item{\code{...}}{(\code{any})\cr ignored.} }