Skip to content

library(mlr3pipelines) makes it required for tests, as opposed to the skip_if_not_installed() usage elsewhere #470

Closed
@MichaelChirico

Description

These two lines are contradictory:

library(mlr3pipelines)

skip_if_not_installed("mlr3pipelines")

Because helper.R is always sourced before running a test_ file.

IMO if {mlr3pipelines} is required for the tests, it is better to put the library() call in tests/testthat.R -- this is the first place a reader will look for test requirements.

If it's indeed optional, I would remove the library() call in helper.R.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions