Skip to content

Better workaround for predict_newdata_fast() #50

@jemus42

Description

@jemus42

It provides a massive speed improvement which we definitely want in all methods where we use it, but due to mlr-org/mlr3pipelines#961 we have to anticipate it not being available for GraphLearners, which I use for simple things like po("removeconstants") or so in the benchmark comparing various methods on various tasks.

When doing performance benchmarking I also need to take into account whether predict_newdata_fast() was used or not.

As an aside: Currently I think there's technically nothing that prevents things like PFI or so to work with survival data, and since predict_newdata_fast() would need a dedicated implementation for survival learners, that's another edge case.

Metadata

Metadata

Assignees

No one assigned

    Labels

    mlr3Issue related to (or caused by) upstream mlr3 behaviorperformanceDoesn't make it more correct but faster or less memory hungry

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions