Skip to content

Commit 3b6e5fe

Browse files
committed
Fixed tiny bug in derivative
1 parent bdc7795 commit 3b6e5fe

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

darmonpoints/schottky.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ def theta_derivative_naive(
274274
for i in NN:
275275
verbose(f"{i = }")
276276
if i > 2 and max_length == -1:
277-
can_stop = True
277+
can_stop = True
278278
for _, g in self.enumerate_group_elements(i):
279279
ga = act(g, a)
280280
gb = act(g, b)
@@ -295,7 +295,7 @@ def theta_derivative_naive(
295295
new_ans = (num / den) * second_term
296296
old_ans = new_ans
297297
val = (new_ans / old_ans - 1).valuation()
298-
if can_stop:
298+
if can_stop or i == max_length:
299299
break
300300
new_ans.add_bigoh(val + new_ans.valuation())
301301
if return_value:

0 commit comments

Comments
 (0)