Adding support for other HTTP clients

[ajutzeler]

HttpsURLConnection is not very flexible (and even broken in my opinion) when it comes to the persistence of the connections.

On all JVM that I tested (openjdk 11-17, oracle 11-17) there is a timeout around 10 seconds, which to my knowledge is not configurable, that will terminate the connection if no subsequent query is sent regardless of OS' configuration.

I quickly and dirtily (dropped all features I did not need and did not update the test suite) modified ResCU to use OKHttp client instead of HttpsURLConnection and all my problems related to that issue disappeared.

Would that make sense to add to this project the support for a more capable HTTP client (not necessarily OKHttp)?

[timmolter]

Did you try this: https://github.com/mmazi/rescu#settings

[ajutzeler]

I did not try to specify explicitly any value, but I was using the 30 secs default values (see class Config in si.mazi.rescu).

In my tests no connection ever lasted 30 secs if queries were not continuously sent around every 10 seconds. The connection timeout is supposed to only be relevant at the initialization (see official javadoc).

[mmazi]

Would that make sense to add to this project the support for a more capable HTTP client (not necessarily OKHttp)?

It certainly seems so. Would you be willing to create a full pull request? That would have to include the tests too. I'd be happy to review it and help with some advice (and perhaps a little coding).

[pcoppinger]

I quickly and dirtily (dropped all features I did not need and did not update the test suite) modified ResCU to use OKHttp client instead of HttpsURLConnection and all my problems related to that issue disappeared.

@ajutzeler I'm having the same problem. What is involved in converting ResCU to OKHttp? Any help (or code) you could offer would be very much appreciated.

[mmazi]

Support for other clients has been added in #148 (and subsequent fixes like #149 #151 #152 #153 #154 ), together with an implementation for the Apache client. This can probably be used as the basis for an OKHttp implementation too.