Skip to content

Giscus repo assumed to be MM site repo #5319

@wsdewitt

Description

@wsdewitt

script.setAttribute('data-repo', '{{ site.repository | downcase }}');

This line assumes the giscus comments are hosted via GitHub Discussions on the very same repo as the MM site, however this need not be the case—e.g. one might want to keep the MM site repo private, and host comments on a public repo.

The giscus config includes a repo variable that is currently ignored by this template. I propose to replace site.repository | downcase with site.comments.giscus.repo (perhaps defaulting to site.repository).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions