fix: accurately handle links with offsets

Author: mnaoumov

src/FrontmatterMarkdownLinksCache.ts

@@ -52,7 +52,6 @@ export class FrontmatterMarkdownLinksCache {
       this.fileFrontmatterLinkCacheMap.set(filePath, links);
     }
 
-    filterInPlace(links, (oldLink) => oldLink.key !== link.key);
     links.push(link);
     this.addStoreAction(FRONTMATTER_LINKS_STORE_NAME, (store) => {
       store.put({ filePath, links });
@@ -130,16 +129,7 @@ export class FrontmatterMarkdownLinksCache {
     const frontmatterLinksStore = transaction.objectStore(FRONTMATTER_LINKS_STORE_NAME);
     const frontmatterLinksEntries = await getResult(frontmatterLinksStore.getAll()) as FrontmatterLinkEntry[];
     for (const entry of frontmatterLinksEntries) {
-      const usedKeys = new Set<string>();
-      const uniqueLinks = [];
-      for (const link of entry.links) {
-        if (usedKeys.has(link.key)) {
-          continue;
-        }
-        usedKeys.add(link.key);
-        uniqueLinks.push(link);
-      }
-      this.fileFrontmatterLinkCacheMap.set(entry.filePath, uniqueLinks);
+      this.fileFrontmatterLinkCacheMap.set(entry.filePath, entry.links);
     }
   }
 

src/Plugin.ts

@@ -456,42 +456,45 @@ export class Plugin extends PluginBase<PluginTypes> {
       processItem: async (note) => {
         cachedFilePaths.delete(note.path);
         if (this.frontmatterMarkdownLinksCache.isCacheValid(note)) {
-          const links = this.frontmatterMarkdownLinksCache.getLinks(note);
-          if (links.length > 0) {
-            const cache = await getCacheSafe(this.app, note);
-            if (cache) {
-              cache.frontmatterLinks ??= [];
-              const currentLinks = new Map<string, FrontmatterLinkCache>();
-
-              for (const link of cache.frontmatterLinks) {
-                currentLinks.set(link.key, link);
-              }
+          const frontmatterMarkdownLinksCacheLinks = this.frontmatterMarkdownLinksCache.getLinks(note);
+          if (frontmatterMarkdownLinksCacheLinks.length === 0) {
+            return;
+          }
+          const cache = await getCacheSafe(this.app, note);
+          if (!cache) {
+            return;
+          }
+          cache.frontmatterLinks ??= [];
 
-              const linkKeys = new Set(links.map((link) => link.key));
-              filterInPlace(cache.frontmatterLinks, (link) => !linkKeys.has(link.key));
-
-              const newLinks: FrontmatterLinkCache[] = [];
-
-              for (const link of links) {
-                const currentLink = currentLinks.get(link.key);
-                if (currentLink && currentLink.original !== link.original) {
-                  cache.frontmatterLinks.push(currentLink);
-                  this.frontmatterMarkdownLinksCache.deleteKey(note.path, link.key);
-                  continue;
-                }
-
-                if (cache.frontmatter && getNestedPropertyValue(cache.frontmatter, link.key) instanceof String) {
-                  cache.frontmatterLinks.push(link);
-                  newLinks.push(link);
-                } else {
-                  this.frontmatterMarkdownLinksCache.deleteKey(note.path, link.key);
-                }
-              }
+          const obsidianLinkMap = new Map<string, FrontmatterLinkCache>();
+
+          for (const link of cache.frontmatterLinks) {
+            obsidianLinkMap.set(link.key, link);
+          }
 
-              for (const link of newLinks) {
-                this.updateResolvedOrUnresolvedLinksCache(link.link, note.path);
+          const frontmatterMarkdownLinksCacheKeys = new Set(frontmatterMarkdownLinksCacheLinks.map((link) => link.key));
+          filterInPlace(cache.frontmatterLinks, (link) => !frontmatterMarkdownLinksCacheKeys.has(link.key));
+
+          const newLinks: FrontmatterLinkCache[] = [];
+
+          for (const link of frontmatterMarkdownLinksCacheLinks) {
+            const value = getNestedPropertyValue(cache.frontmatter ?? {}, link.key);
+            if (value !== link.original) {
+              this.frontmatterMarkdownLinksCache.deleteKey(note.path, link.key);
+              const obsidianLink = obsidianLinkMap.get(link.key);
+              if (obsidianLink) {
+                cache.frontmatterLinks.push(obsidianLink);
+                obsidianLinkMap.delete(link.key);
               }
+              continue;
             }
+
+            cache.frontmatterLinks.push(link);
+            newLinks.push(link);
+          }
+
+          for (const link of newLinks) {
+            this.updateResolvedOrUnresolvedLinksCache(link.link, note.path);
           }
           return;
         }