updating comments of the revision

Author: bruAristimunha

.github/workflows/unit_tests.yml

@@ -311,7 +311,7 @@ jobs:
 
     - uses: actions/cache@v4
       with:
-        key: testing_data-1-${{ env.TESTING_VERSION }}-${{ matrix.os }}-${{ matrix.python-version }}-${{ matrix.mne-version }}
+        key: testing_data-1-${{ env.TESTING_VERSION }}-${{ matrix.mne-version }}
         path: ~/mne_data
       name: 'Cache testing data'
 

mne_bids/tests/test_fileio.py

@@ -3,6 +3,7 @@
 # Authors: The MNE-BIDS developers
 # SPDX-License-Identifier: BSD-3-Clause
 
+import importlib
 import threading
 import time
 from concurrent.futures import ProcessPoolExecutor
@@ -11,6 +12,7 @@
 
 import pytest
 
+import mne_bids._fileio
 from mne_bids._fileio import (
     _canonical_lock_path,
     _decrement_and_cleanup_lock_file,
@@ -549,11 +551,6 @@ def test_environment_variable_timeout(tmp_path, monkeypatch):
     # We need to reload the module with the env var set
     monkeypatch.setenv("MNE_BIDS_FILELOCK_TIMEOUT", "120")
 
-    # Import after setting env var
-    import importlib
-
-    import mne_bids._fileio
-
     importlib.reload(mne_bids._fileio)
 
     assert mne_bids._fileio.DEFAULT_LOCK_TIMEOUT == 120.0
@@ -563,11 +560,6 @@ def test_environment_variable_invalid_timeout(tmp_path, monkeypatch):
     """Test DEFAULT_LOCK_TIMEOUT with invalid environment variable."""
     monkeypatch.setenv("MNE_BIDS_FILELOCK_TIMEOUT", "invalid")
 
-    # Import after setting env var
-    import importlib
-
-    import mne_bids._fileio
-
     importlib.reload(mne_bids._fileio)
 
     # Should fall back to default

mne_bids/tsv_handler.py

@@ -200,7 +200,6 @@ def _to_tsv(data, fname):
     with _open_lock(fname, "w", encoding="utf-8-sig") as f:
         f.write(output)
         f.write("\n")
-        f.flush()  # Ensure data is written to disk before lock is released
 
 
 def _tsv_to_str(data, rows=5):

mne_bids/write.py

@@ -702,7 +702,7 @@ def _participants_json(fname, overwrite=False):
             except json.JSONDecodeError as e:
                 # File is corrupted/incomplete - this can happen in a race condition
                 # when one process truncates while another reads
-                logger.debug(
+                logger.warning(
                     f"Could not parse JSON in '{fname}': {e}. "
                     "This may occur when reading during concurrent writes. "
                     "Treating as empty."