Always test but catch the eventual warning

Author: PierreGtch

mne_bids/tests/test_read.py

@@ -11,6 +11,7 @@
 from contextlib import nullcontext
 from datetime import datetime, timezone
 from pathlib import Path
+import contextlib
 
 import mne
 import numpy as np
@@ -493,18 +494,7 @@ def test_get_head_mri_trans(tmp_path):
 
 
 @testing.requires_testing_data
-@pytest.mark.parametrize(
-    "with_extras",
-    [
-        False,
-        pytest.param(
-            True,
-            marks=pytest.mark.skipif(
-                not check_version("mne", "1.10"), reason="not implemented"
-            ),
-        ),
-    ],
-)
+@pytest.mark.parametrize("with_extras", [False, True])
 def test_handle_events_reading(tmp_path, with_extras):
     """Test reading events from a BIDS events.tsv file."""
     # We can use any `raw` for this
@@ -523,12 +513,25 @@ def test_handle_events_reading(tmp_path, with_extras):
     events_fname.parent.mkdir()
     _to_tsv(events, events_fname)
 
-    raw, event_id = _handle_events_reading(events_fname, raw)
+    with (
+        pytest.warns(
+            RuntimeWarning,
+            match=(
+                "The version of MNE-Python you are using (<1.10) "
+                "does not support the extras argument in mne.Annotations. "
+                "The extra column(s) ['foo'] will be ignored."
+            ),
+        )
+        if with_extras and not check_version("mne", "1.10")
+        else contextlib.nullcontext()
+    ):
+        raw, event_id = _handle_events_reading(events_fname, raw)
+
     ev_arr, ev_dict = mne.events_from_annotations(raw)
     assert list(ev_dict.values()) == [1, 2]  # auto-assigned
     want = len(events["onset"]) - 1  # one onset was n/a
     assert want == len(raw.annotations) == len(ev_arr) == len(ev_dict)
-    if with_extras:
+    if with_extras and check_version("mne", "1.10"):
         for d, v in zip(raw.annotations.extras, "abc"):
             assert "foo" in d
             assert d["foo"] == v
@@ -873,9 +876,7 @@ def test_handle_chpi_reading(tmp_path):
     meg_json_data_freq_mismatch["HeadCoilFrequency"][0] = 123
     _write_json(meg_json_path, meg_json_data_freq_mismatch, overwrite=True)
 
-    with (
-        pytest.warns(RuntimeWarning, match="Defaulting to .* mne.Raw object"),
-    ):
+    with (pytest.warns(RuntimeWarning, match="Defaulting to .* mne.Raw object"),):
         raw_read = read_raw_bids(bids_path, extra_params=dict(allow_maxshield="yes"))
 
     # cHPI "off" according to sidecar, but present in the data
@@ -1096,9 +1097,7 @@ def test_handle_ieeg_coords_reading(bids_path, tmp_path):
     _to_tsv(electrodes_dict, electrodes_fname)
     # popping off channels should not result in an error
     # however, a warning will be raised through mne-python
-    with (
-        pytest.warns(RuntimeWarning, match="DigMontage is only a subset of info"),
-    ):
+    with (pytest.warns(RuntimeWarning, match="DigMontage is only a subset of info"),):
         read_raw_bids(bids_path=bids_fname, verbose=False)
 
     # make sure montage is set if there are coordinates w/ 'n/a'
@@ -1114,9 +1113,7 @@ def test_handle_ieeg_coords_reading(bids_path, tmp_path):
     # electrode coordinates should be nan
     # when coordinate is 'n/a'
     nan_chs = [electrodes_dict["name"][i] for i in [0, 3]]
-    with (
-        pytest.warns(RuntimeWarning, match="There are channels without locations"),
-    ):
+    with (pytest.warns(RuntimeWarning, match="There are channels without locations"),):
         raw = read_raw_bids(bids_path=bids_fname, verbose=False)
         for idx, ch in enumerate(raw.info["chs"]):
             if ch["ch_name"] in nan_chs:
@@ -1244,9 +1241,7 @@ def test_handle_non_mne_channel_type(tmp_path):
     channels_data["type"][ch_idx] = "FOOBAR"
     _to_tsv(data=channels_data, fname=channels_tsv_path)
 
-    with (
-        pytest.warns(RuntimeWarning, match='will be set to "misc"'),
-    ):
+    with (pytest.warns(RuntimeWarning, match='will be set to "misc"'),):
         raw = read_raw_bids(bids_path)
 
     # Should be a 'misc' channel.