Skip to content

Commit 8256b3e

Browse files
authored
Merge branch 'main' into fix/channel-mismatch
2 parents 358545b + 51126eb commit 8256b3e

File tree

19 files changed

+1347
-138
lines changed

19 files changed

+1347
-138
lines changed

.github/workflows/unit_tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ jobs:
212212
uses: actions/cache@v4
213213
with:
214214
path: ${{ env.pythonLocation }}
215-
key: test-2-${{ env.pythonLocation }}-${{ env.os }}-${{ hashFiles('pyproject.toml') }}
215+
key: test-2-${{ env.pythonLocation }}-${{ matrix.os }}-${{ matrix.python-version }}-${{ matrix.mne-version }}-${{ hashFiles('pyproject.toml') }}
216216

217217
- name: Install Python dependencies using pip
218218
# This would be nicer once this feature is implemented: https://github.com/pypa/pip/issues/11440
@@ -311,7 +311,7 @@ jobs:
311311

312312
- uses: actions/cache@v4
313313
with:
314-
key: testing_data-1-${{ env.TESTING_VERSION }}
314+
key: testing_data-1-${{ env.TESTING_VERSION }}-${{ matrix.mne-version }}
315315
path: ~/mne_data
316316
name: 'Cache testing data'
317317

doc/Makefile

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,22 @@ help:
1818
# Catch-all target: route all unknown targets to Sphinx using the new
1919
# "make mode" option. $(O) is meant as a shortcut for $(SPHINXOPTS).
2020
%: Makefile
21-
@$(SPHINXBUILD) -M $@ "$(SOURCEDIR)" "$(BUILDDIR)" $(SPHINXOPTS) $(O)
21+
@$(SPHINXBUILD) -M $@ "$(SOURCEDIR)" "$(BUILDDIR)" $(O)
22+
23+
# Build without executing the example gallery (faster)
24+
html-noplot:
25+
@$(SPHINXBUILD) $(SPHINXOPTS) -D plot_gallery=0 $(SOURCEDIR) $(BUILDDIR)
2226

2327
# View the built documentation
28+
# If we build the example gallery, the index file is at _build/html/index.html
29+
# If we don't (e.g. html-noplot), then it is at _build/index.html
2430
view:
25-
@python -c "import webbrowser; webbrowser.open_new_tab('file://$(PWD)/_build/html/index.html')"
31+
@if [ -f "$(BUILDDIR)/html/index.html" ]; then \
32+
python -c "import webbrowser; webbrowser.open_new_tab('file://$(PWD)/$(BUILDDIR)/html/index.html')"; \
33+
elif [ -f "$(BUILDDIR)/index.html" ]; then \
34+
python -c "import webbrowser; webbrowser.open_new_tab('file://$(PWD)/$(BUILDDIR)/index.html')"; \
35+
else echo "No index.html file found to open. Did you build the docs?"; \
36+
fi
2637

2738
clean:
2839
-rm -rf _build auto_examples generated

doc/install.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ Optional:
2626
* ``pandas`` (>=1.3.2, for generating event statistics)
2727
* ``edfio`` (>=0.4.10, for writing EDF data)
2828
* ``defusedxml`` (for writing reading EGI MFF data and BrainVision montages)
29+
* ``filelock`` (for atomic file writing, and parallel processing support)
2930

3031
We recommend installing ``mne-bids`` into an isolated Python environment,
3132
for example created via ``conda``

doc/whats_new.rst

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ Detailed list of changes
3939
- :func:`mne_bids.write_raw_bids()` has a new parameter `electrodes_tsv_task` which allows adding the `task` entity to the `electrodes.tsv` filepath, by `Alex Lopez Marquez`_ (:gh:`1424`)
4040
- Extended the configuration to recognise `motion` as a valid BIDS datatype by `Julius Welzel`_ (:gh:`1430`)
4141
- Better control of verbosity in several functions, by `Bruno Aristimunha`_ (:gh:`1449`)
42+
- Added parallel reading and writing in all the `open` operations using `_open_lock` mechanism from mne, creating a small wrapper to manage the locks by `Bruno Aristimunha`_ (:gh:`1451`)
4243
- :meth:`mne_bids.BIDSPath.match()` now short-circuits root directory scans when ``subject``, ``session``, or ``datatype`` entities are known, reducing lookup time on large datasets, by `Bruno Aristimunha`_ and `Maximilien Chaumon`_ (:gh:`1450`)
4344

4445
🧐 API and behavior changes
@@ -48,6 +49,7 @@ Detailed list of changes
4849

4950
🛠 Requirements
5051
^^^^^^^^^^^^^^^
52+
- Including ``filelock`` as a dependency to handle atomic file writing and parallel processing support by `Bruno Aristimunha`_ (:gh:`1451`)
5153

5254
- None yet
5355

@@ -56,6 +58,7 @@ Detailed list of changes
5658

5759
- Fixed a bug that modified the name and help message of some of the available commands, by `Alex Lopez Marquez`_ (:gh:`1441`)
5860
- Updated MEG/iEEG writers to satisfy the stricter checks in the latest BIDS validator releases: BTi/4D run folders now retain their ``.pdf`` suffix (falling back to the legacy naming when an older validator is detected), KIT marker files encode the run via the ``acq`` entity instead of ``run``, datasets lacking iEEG montages receive placeholder ``electrodes.tsv``/``coordsystem.json`` files, and the ``AssociatedEmptyRoom`` entry stores dataset-relative paths by `Bruno Aristimunha`_ (:gh:`1449`)
61+
- Fixed a bug in :func:`mne_bids.read_raw_bids` that caused it to fail when reading BIDS datasets where the acquisition time was specified in local time rather than UTC only in Windows, by `Bruno Aristimunha`_ (:gh:`1452`)
5962

6063
⚕️ Code health
6164
^^^^^^^^^^^^^^

0 commit comments

Comments
 (0)