Merge branch 'main' into main

Author: JuliusWelzel

.github/workflows/release.yml

@@ -22,7 +22,7 @@ jobs:
         with:
           fetch-depth: 0
           fetch-tags: true
-      - uses: actions/setup-python@v5
+      - uses: actions/setup-python@v6
         with:
           python-version: '3.13'
       - name: Install dependencies

.github/workflows/unit_tests.yml

@@ -26,7 +26,7 @@ jobs:
         fetch-depth: 0
         fetch-tags: true
     - name: Set up Python ${{ matrix.python-version }}
-      uses: actions/setup-python@v5
+      uses: actions/setup-python@v6
       with:
         python-version: ${{ matrix.python-version }}
     - uses: actions/cache@v4
@@ -54,7 +54,7 @@ jobs:
         python-version: ["3.10", "3.13"]  # Oldest and newest supported versions
     steps:
     - name: Set up Python ${{ matrix.python-version }}
-      uses: actions/setup-python@v5
+      uses: actions/setup-python@v6
       with:
         python-version: ${{ matrix.python-version }}
 
@@ -180,12 +180,12 @@ jobs:
         fetch-tags: true
 
     - name: Set up Node.js
-      uses: actions/setup-node@v4
+      uses: actions/setup-node@v5
       with:
         node-version: 20
 
     - name: Set up Python ${{ matrix.python-version }}
-      uses: actions/setup-python@v5
+      uses: actions/setup-python@v6
       with:
         python-version: ${{ matrix.python-version }}
 
@@ -309,7 +309,7 @@ jobs:
         fetch-depth: 0
         fetch-tags: true
     - name: Set up Python ${{ matrix.python-version }}
-      uses: actions/setup-python@v5
+      uses: actions/setup-python@v6
       with:
         python-version: ${{ matrix.python-version }}
     - uses: actions/cache@v4

.pre-commit-config.yaml

@@ -1,6 +1,6 @@
 repos:
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.12.9
+    rev: v0.12.11
     hooks:
       - id: ruff
         name: ruff mne_bids/

CITATION.cff

@@ -214,6 +214,9 @@ authors:
       family-names: Ritz
       affiliation: 'Princeton Neuroscience Institute, Princeton University, Princeton, USA'
       orcid: 'https://orcid.org/0009-0003-1477-4912'
+    - given-names: Nathan
+      family-names: Azrak
+      orcid: 'https://orcid.org/0000-0001-7695-4634'
     - given-names: Alexandre
       family-names: Gramfort
       affiliation: 'Université Paris-Saclay, Inria, CEA, Palaiseau, France'

doc/authors.rst

@@ -40,6 +40,7 @@
 .. _Matthias Dold: https://www.linkedin.com/in/matthiasdold/
 .. _Maximilien Chaumon: https://github.com/dnacombo
 .. _Moritz Gerster: http://moritz-gerster.com
+.. _Nathan Azrak: https://github.com/nathan-az
 .. _Pierre Guetschel: https://github.com/PierreGtch
 .. _Richard Höchenberger: https://github.com/hoechenberger
 .. _Richard Köhler: https://github.com/richardkoehler

doc/whats_new.rst

@@ -23,6 +23,8 @@ The following authors contributed for the first time. Thank you so much! 🤩
 * `Matthias Dold`_
 * `Harrison Ritz`_
 * `Julius Welzel`_
+* `Nathan Azrak`_
+
 
 The following authors had contributed before. Thank you for sticking around! 🤘
 
@@ -45,6 +47,7 @@ Detailed list of changes
 - :func:`mne_bids.get_entity_vals()` has a new parameter ``include_match`` to prefilter item matching and ignore non-matched items from begin of directory scan, by `Arne Gottwald` (:gh:`1355`)
 - Data from ``events.tsv`` can now be read into an OrderedDict using :func:`mne_bids.events_file_to_annotation_kwargs()`, by `Matthias Dold` (:gh:`1389`)
 - Read the optionally present extra columns from ``events.tsv`` and pass them to :class:`mne.Annotations`, by `Pierre Guetschel` (:gh:`1401`)
+- ``_filter_fnames()`` now correctly checks the default extension, correcting suffix filtering, by `Nathan Azrak` (:gh:`1427`)
 
 
 🧐 API and behavior changes

mne_bids/path.py

@@ -2377,7 +2377,7 @@ def _filter_fnames(
         r"_desc-(" + "|".join(description) + ")" if description else r"(|_desc-([^_]+))"
     )
     suffix_str = r"_(" + "|".join(suffix) + ")" if suffix else r"_([^_]+)"
-    ext_str = r"(" + "|".join(extension) + ")$" if extension else r".([^_]+)"
+    ext_str = r"(" + "|".join(extension) + ")$" if extension else r"\.([^_]+)"
 
     regexp = (
         leading_path_str

mne_bids/tests/test_path.py

@@ -1029,6 +1029,7 @@ def test_filter_fnames(entities, expected_n_matches):
         "sub-Foo_ses-bar_meg.fif",
         "sub-Bar_task-invasive_run-1_ieeg.fif",
         "sub-3_task-fun_proc-sss_meg.fif",
+        "sub-3_task-fun_proc-sss_meg_channels.tsv",
         "sub-4_task-pain_acq-lowres_T1w.nii.gz",
         "sub-5_task-test_proc-ica_eeg.vhdr",
         "sub-6_task-test_proc-ica_eeg.vhdr",