FIX: Support UTF-8 encoding for JSON files #1357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scott-huberty
changed the title
Member
|
I don't think we want to convert to ASCII for any JSON we're writing to disk. Hence, we don't need a parameter to control this behavior :) |
This reverts commit 4c47679.
TIL: That json.loads will always convert unicode. So to test that unicode was properly encoded while writing to disk, I had to had to just read the text on disk without the json module
hoechenberger
approved these changes
Dec 20, 2024
drammock
approved these changes
Dec 20, 2024
Member
drammock
left a comment
drammock
left a comment
There was a problem hiding this comment.
LGTM, nice adaptation of the existing test. One suggested improvement, see below
Instead of closing and re-opening the file, rewind the "playhead" to the start of the open file, then use fid.read() as usual Co-authored-by: Daniel McCloy <[email protected]>
scott-huberty
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1357 +/- ##
=======================================
Coverage 97.42% 97.42%
=======================================
Files 40 40
Lines 8918 8921 +3
=======================================
+ Hits 8688 8691 +3
Misses 230 230 ☔ View full report in Codecov by Sentry. |
Member
|
Thanks @scott-huberty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1356
_write_jsonis used a lot in the MNE-BIDS codebase... I want to get your feedback on whether adding a new parameterensure_ascii=Falseto_write_tsvis the right way to go?Because I'm not sure if there are cases in MNE-BIDS where we do want to enforce ASCII encoding during JSON writing.. If so, we could change the default to
ensure_ascii=True, and passFalseexplicitly for the cases where we want to support UTF-8?cc @sappelhoff @hoechenberger @larsoner
TODO