FIX: Use "recording" for recording entity, not "rec" #1359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Member
|
@drammock @scott-huberty @hoechenberger I am off on holidays and also sick with a cold, so I would be very grateful if the three of you could review each other and merge the open PRs (and future ones for this month). Thanks a lot for your work, and I'll get back early next year. If this doesn't work we will just have to wait a few weeks until I'm back. |
Collaborator
Author
|
No problem @sappelhoff , I am happy to help. Happy holidays (and feel better)! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1359 +/- ##
=======================================
Coverage 97.42% 97.42%
=======================================
Files 40 40
Lines 8921 8921
=======================================
Hits 8691 8691
Misses 230 230 ☔ View full report in Codecov by Sentry. |
Member
|
Thanks @scott-huberty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1348
See: https://bids-specification.readthedocs.io/en/stable/modality-specific-files/physiological-recordings.html
As @kaare-mikkelsen pointed out, BEP 020 will make use of the
recordingentity for eyetracking data. And since I'm working on #1342 , this should be fixed first 🙂Merge checklist
Maintainer, please confirm the following before merging.
If applicable: