BUG: Fix bug with path search

[larsoner]

Closes #1376

[larsoner]

This was the real bug. All else is just cleanups + test

[larsoner]

Yikes the benchmark test takes 60 seconds (!). It also no longer passes for me locally. I'll see if the speedup comes from

        paths = [
            Path(root, fn)
            for fn in glob.iglob(search_str, root_dir=root, recursive=True)
        ]

in which case it should be used in both code paths. But that would be weird...

[drammock]

I'd also like to fixup a couple things about #1355 while this is open. I see you already restored the versionchanged (thanks!). My TODO list:

• some of the changelog entries reference private functions, should reword / remove
• the docstring for include_match is IMO very hard to understand, and the param name itself doesn't really help.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.47%. Comparing base (b75e4ca) to head (93d30b6).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1379      +/-   ##
==========================================
+ Coverage   97.37%   97.47%   +0.09%     
==========================================
  Files          40       40              
  Lines        8966     9024      +58     
==========================================
+ Hits         8731     8796      +65     
+ Misses        235      228       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[larsoner]

Okay should be good to go @drammock

[drammock]

LGTM, just one tiny docstring tweak. I'll apply it and merge. Thanks @larsoner