Skip to content

Conversation

@PierreGtch
Copy link
Contributor

PR Description

Fixes #1387. Does so by ensuring that the basename used in glob is imediatly followed by a separator.

I considered two separators: ”_" and ”.”. Did I miss some separators @hoechenberger ?

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

  • All comments are resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • New contributors have been added to CITATION.cff
  • PR description includes phrase "closes <#issue-number>"

@PierreGtch
Copy link
Contributor Author

@hoechenberger ready for review :)

@codecov
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.48%. Comparing base (4ac8005) to head (0120653).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1388   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files          40       40           
  Lines        9014     9023    +9     
=======================================
+ Hits         8787     8796    +9     
  Misses        227      227           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@hoechenberger hoechenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Excellent, @PierreGtch

@hoechenberger hoechenberger merged commit 5d4320f into mne-tools:main Mar 28, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Is zero-padding mandatory in indices?

3 participants