Skip to content

Conversation

@Aaronearlerichardson
Copy link
Contributor

@Aaronearlerichardson Aaronearlerichardson commented Apr 29, 2025

PR Description

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

  • All comments are resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • New contributors have been added to CITATION.cff
  • PR description includes phrase "closes <#issue-number>"

@codecov
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.94%. Comparing base (1587130) to head (b82e298).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1399      +/-   ##
==========================================
- Coverage   97.41%   96.94%   -0.47%     
==========================================
  Files          41       41              
  Lines        9371     9371              
==========================================
- Hits         9129     9085      -44     
- Misses        242      286      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the general CI has now been fixed, so failures here are related to the present commit.

@sappelhoff
Copy link
Member

@Aaronearlerichardson if you want to get this change merged, you would need to look into why the CIs are failing. 🙂

@sappelhoff
Copy link
Member

... cc @bruAristimunha in case you are still hunting for issues and PRs that you can take care of 😉

@bruAristimunha
Copy link
Contributor

hey @Aaronearlerichardson,

I can support you with this pr. Can you give me permission into your mne-bids fork? You will need to add me as a collaborator in the repository, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing to load clinical Brainvision formatted ECoG data in MNE tutorial due to timezones

3 participants