Skip to content

Conversation

@sappelhoff
Copy link
Member

PR Description

as an attempt to help debugging

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

  • All comments are resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • New contributors have been added to CITATION.cff
  • PR description includes phrase "closes <#issue-number>"

@codecov
Copy link

codecov bot commented May 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.49%. Comparing base (4f12d19) to head (34c487c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1406   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files          40       40           
  Lines        9060     9060           
=======================================
  Hits         8833     8833           
  Misses        227      227           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hoechenberger
Copy link
Member

this is so weird ..... 😐

@sappelhoff
Copy link
Member Author

Perhaps we produce that file somewhere and save it in the mne testing data 😱

@hoechenberger
Copy link
Member

@sappelhoff Can you remove your testing data and download it again and then see what happens if you re-run the tests?

@sappelhoff
Copy link
Member Author

Can you remove your testing data and download it again and then see what happens if you re-run the tests?

yes, I believe it gets written, look at date modified:

image

@sappelhoff
Copy link
Member Author

we have two culprits:

er_raw_fname = data_path / "MEG" / "sample" / "ernoise_raw.fif"
raw.copy().crop(0, 10).save(er_raw_fname, overwrite=True)
er_raw = _read_raw_fif(er_raw_fname)

er_raw_fname = data_path / "MEG" / "sample" / "ernoise_raw.fif"
raw.copy().crop(0, 10).save(er_raw_fname, overwrite=True)
er_raw = _read_raw_fif(er_raw_fname)

@sappelhoff
Copy link
Member Author

That's bad practice and we should fix it 👼

@hoechenberger
Copy link
Member

Ouch!!!

@sappelhoff
Copy link
Member Author

@sappelhoff sappelhoff closed this May 27, 2025
@sappelhoff sappelhoff deleted the bump branch May 27, 2025 08:55
@hoechenberger
Copy link
Member

Thanks, Stefan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants