FIX, DOC: Dont pair recording parameter w/ rec BIDS entity #1417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1417 +/- ##
=======================================
Coverage 97.46% 97.46%
=======================================
Files 40 40
Lines 9096 9096
=======================================
Hits 8865 8865
Misses 231 231 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hoechenberger
approved these changes
Jul 3, 2025
Member
|
LGTM, thanks @scott-huberty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on some things I missed in #1359, I found two places where the API doc suggested that the
recordingparameter refers to the "rec" entity in BIDS (for example in the BIDSPath constructor). As we realized before, "rec" actually stands for reconstruction, and there is a stand alone "recording" entity in BIDS.