Skip to content

Conversation

@harrisonritz
Copy link
Contributor

PR Description

Hi, first time PR.
Very minor, just add T2w to suffix allowlist. Arose by following laMEG recommendations.
Didn't add test because it's so minor. Feel free to decide whether I should be added to authors.

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

  • All comments are resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • New contributors have been added to CITATION.cff
  • PR description includes phrase "closes <#issue-number>"

@welcome
Copy link

welcome bot commented Jul 21, 2025

Hello! 👋 Thanks for opening your first pull request here!
Please read the contributor guide, and please follow the steps outlined in the "Instructions for first-time contributors" section therein. ❤️ We will try to get back to you soon. 🚴🏽‍♂️

@codecov
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.46%. Comparing base (23e4b99) to head (bd2c847).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1420   +/-   ##
=======================================
  Coverage   97.46%   97.46%           
=======================================
  Files          40       40           
  Lines        9096     9096           
=======================================
  Hits         8865     8865           
  Misses        231      231           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@harrisonritz harrisonritz marked this pull request as ready for review July 21, 2025 18:17
Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @harrisonritz!

@sappelhoff sappelhoff enabled auto-merge (squash) July 21, 2025 20:37
@sappelhoff sappelhoff merged commit 80e3fbd into mne-tools:main Jul 21, 2025
25 checks passed
@welcome
Copy link

welcome bot commented Jul 21, 2025

🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants