Skip to content

Conversation

@scott-huberty
Copy link
Collaborator

@scott-huberty scott-huberty commented Aug 12, 2025

We want to install sphinx-gallery in a way that ensures .git metadata is included, otherwise installation will fail because setuptools-scm won't be able to infer the sphinx-gallery package version.

see: #1424 (comment)

Let's see if this fixes the doc CI.. and @sappelhoff @hoechenberger let me know either of you still think that this is an upstream packaging bug.

We want to install SG in a way that the git metadata is present, otherwise installation will fail because setuptools-scm won't be able to infer the SG package verion

see: mne-tools#1424 (comment)
@hoechenberger
Copy link
Member

hoechenberger commented Aug 12, 2025

No, we shouldn't have to do this. The sphinx gallery team needs to fix this upstream. They need to add a .git_archival.txt file to their repository.

Edit: And a .gitattributes file.

@codecov
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.46%. Comparing base (59e61e3) to head (50e57b4).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1428   +/-   ##
=======================================
  Coverage   97.46%   97.46%           
=======================================
  Files          40       40           
  Lines        9096     9096           
=======================================
  Hits         8865     8865           
  Misses        231      231           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scott-huberty
Copy link
Collaborator Author

No, we shouldn't have to do this. The sphinx gallery team needs to fix this upstream. They need to add a .git_archival.txt file to their repository.

Edit: And a .gitattributes file.

Ah OK. feel free to close this, or merge it as a temporary fix.

@hoechenberger
Copy link
Member

I'll let sb else take action, just wanted to give you a pointer :)

@scott-huberty
Copy link
Collaborator Author

Resolved by #1438

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants