-
Notifications
You must be signed in to change notification settings - Fork 98
[MRG] Switch to mne python verbose decorator #1449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Switch to mne python verbose decorator #1449
Conversation
…ub.com/bruAristimunha/mne-bids into switch-to-mne-python-verbose-decorator
|
Hello! 👋 Thanks for opening your first pull request here! |
|
cc @hoechenberger could you review this one? |
sappelhoff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bruAristimunha please follow the steps here: https://github.com/mne-tools/mne-bids/blob/main/CONTRIBUTING.md#instructions-for-first-time-contributors
specifically, adding yourself to the list of contributors etc 🙂
|
The tests are failing for an uncorrelated issue that I will address with the last PR #1302 |
|
I will wait the #1302 be merged @sappelhoff ;p |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1449 +/- ##
==========================================
+ Coverage 97.30% 97.40% +0.10%
==========================================
Files 40 41 +1
Lines 9240 9290 +50
==========================================
+ Hits 8991 9049 +58
+ Misses 249 241 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sappelhoff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bruAristimunha I think Richard may be busy and might not have time to have a look at this.
Could you please remove the inline comments that are "questions"? I think we can then go ahead with merging this PR and improve it in the future if needed.
|
done @sappelhoff :) |
sappelhoff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪 |
PR Description
Merge checklist
Maintainer, please confirm the following before merging.
If applicable: