Skip to content

Conversation

@bruAristimunha
Copy link
Contributor

@bruAristimunha bruAristimunha commented Oct 9, 2025

PR Description

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

  • All comments are resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • New contributors have been added to CITATION.cff
  • PR description includes phrase "closes <#issue-number>"

@welcome
Copy link

welcome bot commented Oct 9, 2025

Hello! 👋 Thanks for opening your first pull request here!
Please read the contributor guide, and please follow the steps outlined in the "Instructions for first-time contributors" section therein. ❤️ We will try to get back to you soon. 🚴🏽‍♂️

@sappelhoff
Copy link
Member

cc @hoechenberger could you review this one?

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bruAristimunha please follow the steps here: https://github.com/mne-tools/mne-bids/blob/main/CONTRIBUTING.md#instructions-for-first-time-contributors

specifically, adding yourself to the list of contributors etc 🙂

@sappelhoff sappelhoff mentioned this pull request Oct 9, 2025
7 tasks
@bruAristimunha
Copy link
Contributor Author

The tests are failing for an uncorrelated issue that I will address with the last PR #1302

@bruAristimunha
Copy link
Contributor Author

I will wait the #1302 be merged @sappelhoff ;p

@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

❌ Patch coverage is 92.98246% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.40%. Comparing base (1b5da1b) to head (df13845).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
mne_bids/tests/test_verbose.py 88.88% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1449      +/-   ##
==========================================
+ Coverage   97.30%   97.40%   +0.10%     
==========================================
  Files          40       41       +1     
  Lines        9240     9290      +50     
==========================================
+ Hits         8991     9049      +58     
+ Misses        249      241       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bruAristimunha I think Richard may be busy and might not have time to have a look at this.

Could you please remove the inline comments that are "questions"? I think we can then go ahead with merging this PR and improve it in the future if needed.

@bruAristimunha
Copy link
Contributor Author

done @sappelhoff :)

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sappelhoff sappelhoff merged commit 941a12c into mne-tools:main Oct 10, 2025
24 of 25 checks passed
@welcome
Copy link

welcome bot commented Oct 10, 2025

🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪

@drammock drammock mentioned this pull request Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to silence warnings in mne_bids.write_raw_bids() Switch to MNE-Python @verbose decorator

2 participants