-
Notifications
You must be signed in to change notification settings - Fork 98
Fix import handling for filelock dependency #1469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can we add some test that would have caught this failure? Like a test that only runs if |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1469 +/- ##
==========================================
- Coverage 96.92% 96.90% -0.02%
==========================================
Files 43 43
Lines 10003 10015 +12
==========================================
+ Hits 9695 9705 +10
- Misses 308 310 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
mocked test done :) |
|
Marking for merge-when-green, thanks in advance @bruAristimunha ! |
|
Appears to have fixed the failure observed in mne-tools/mne-nirs#647, thanks for the lightning quick fix @bruAristimunha ! |
PR Description
Improve error handling by ensuring lock helpers skip reference counting when the optional
filelockdependency is missing, preventing potential crashes during reads.Merge checklist
Maintainer, please confirm the following before merging.
If applicable: