Skip to content

Conversation

@bruAristimunha
Copy link
Contributor

PR Description

Improve error handling by ensuring lock helpers skip reference counting when the optional filelock dependency is missing, preventing potential crashes during reads.

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

  • All comments are resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • New contributors have been added to CITATION.cff
  • PR description includes phrase "closes <#issue-number>"

@larsoner
Copy link
Member

larsoner commented Nov 4, 2025

Can we add some test that would have caught this failure? Like a test that only runs if FileLock is not installed? Or monkey-patches to pretend like it's not installed or something...

@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.90%. Comparing base (51126eb) to head (9caaed5).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1469      +/-   ##
==========================================
- Coverage   96.92%   96.90%   -0.02%     
==========================================
  Files          43       43              
  Lines       10003    10015      +12     
==========================================
+ Hits         9695     9705      +10     
- Misses        308      310       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bruAristimunha
Copy link
Contributor Author

mocked test done :)

@larsoner
Copy link
Member

larsoner commented Nov 4, 2025

Marking for merge-when-green, thanks in advance @bruAristimunha !

@larsoner larsoner enabled auto-merge (squash) November 4, 2025 15:44
@larsoner larsoner merged commit 5102e11 into mne-tools:main Nov 4, 2025
23 of 24 checks passed
@larsoner
Copy link
Member

larsoner commented Nov 4, 2025

Appears to have fixed the failure observed in mne-tools/mne-nirs#647, thanks for the lightning quick fix @bruAristimunha !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants