Skip to content

Conversation

@larsoner
Copy link
Member

@larsoner larsoner commented Nov 4, 2025

A comment over in #1466 made me realize we should add this sorter. We use it in MNE-Python. Nice it doesn't catch anything new here! (I deleted the duplicate entry same is in #1466, though.)

@drammock drammock enabled auto-merge (squash) November 4, 2025 16:18
@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.92%. Comparing base (5102e11) to head (5dec3f7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1470   +/-   ##
=======================================
  Coverage   96.92%   96.92%           
=======================================
  Files          43       43           
  Lines       10015    10015           
=======================================
  Hits         9707     9707           
  Misses        308      308           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@drammock
Copy link
Member

drammock commented Nov 4, 2025

@larsoner
Copy link
Member Author

larsoner commented Nov 4, 2025

I'll try restarting the run (once it's an option) since you already linked to the failure @drammock . If it comes back green, it suggests that the problem / failure is intermittent, which already seems likely since a couple of PRs have been green. Would be good to make it reliably pass!

@drammock drammock merged commit 465dd55 into mne-tools:main Nov 4, 2025
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants