Skip to content

Conversation

@bruAristimunha
Copy link
Contributor

PR Description

A continuation of the #1469

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

  • All comments are resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • New contributors have been added to CITATION.cff
  • PR description includes phrase "closes <#issue-number>"

@bruAristimunha
Copy link
Contributor Author

@drammock FYI

@bruAristimunha bruAristimunha changed the title fixing the test write parallel [WIP] fixing the test write parallel Nov 6, 2025
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.94%. Comparing base (60830be) to head (49b6b5e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1473   +/-   ##
=======================================
  Coverage   96.94%   96.94%           
=======================================
  Files          43       43           
  Lines       10074    10077    +3     
=======================================
+ Hits         9766     9769    +3     
  Misses        308      308           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bruAristimunha bruAristimunha changed the title [WIP] fixing the test write parallel [MRG] fixing the test write parallel Nov 6, 2025
@larsoner larsoner merged commit 1e0a96e into mne-tools:main Nov 6, 2025
24 checks passed
@larsoner
Copy link
Member

larsoner commented Nov 6, 2025

Thanks @bruAristimunha !

@drammock
Copy link
Member

drammock commented Nov 6, 2025

I think this was merged a bit hastily. This PR added the test dependency https://github.com/pytest-dev/pytest-rerunfailures, but MNE-Python is using https://github.com/box/flaky. Unfortunately both use @pytest.mark.flaky as the mark name, but with different params. I feel pretty strongly that they should both be using the same one; otherwise it will be a bit of a headache for devs who work on both projects to have one environment with 2 pytest plugins that both define the same mark name. @larsoner should we:

  1. switch MNE-Python to pytest-rerunfailures (on the grounds that it's developed by pytest-dev org, so in some sense "blessed" and likely to be stable)
  2. switch MNE-BIDS to use flaky (because it's what we've been using in MNE-Python and it's been fine)

@larsoner
Copy link
Member

larsoner commented Nov 6, 2025

I figured the one here was better because its pypistats downloads were 5x higher. If it's pytest-dev developed, even better! We should switch MNE-Python

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants