Skip to content

split preload test #1474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2025
Merged

split preload test #1474

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a53d676
split preload test
drammock Nov 6, 2025
baebd12
fix test
drammock Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 25 additions & 7 deletions mne_bids/tests/test_write.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@
"ignore:Channel mismatch between .*channels\\.tsv and the raw data file "
"detected\\.:RuntimeWarning:mne"
),
converting_to_edf=r"ignore:Converting data files to [BE]DF format:RuntimeWarning",
edf_date="ignore:.*limits dates to after 1985-01-01:RuntimeWarning",
)


Expand Down Expand Up @@ -3749,8 +3751,8 @@ def test_write_associated_emptyroom(_bids_validate, tmp_path, empty_room_dtype):
assert meg_json_data["AssociatedEmptyRoom"] == expected_rel


def test_preload(_bids_validate, tmp_path):
"""Test writing custom preloaded raw objects."""
def test_preload_errors(tmp_path):
"""Test allow_preload error handling."""
bids_root = tmp_path / "bids"
bids_path = _bids_path.copy().update(root=bids_root)
sfreq, n_points = 1024.0, int(1e6)
Expand All @@ -3760,21 +3762,37 @@ def test_preload(_bids_validate, tmp_path):
raw.orig_format = "single"
raw.info["line_freq"] = 60

shared_kwargs = dict(raw=raw, bids_path=bids_path, verbose=False, overwrite=True)
# reject preloaded by default
with pytest.raises(ValueError, match="allow_preload"):
write_raw_bids(raw, bids_path, verbose=False, overwrite=True)
write_raw_bids(**shared_kwargs)

# preloaded raw must specify format
with pytest.raises(ValueError, match="format"):
write_raw_bids(
raw, bids_path, allow_preload=True, verbose=False, overwrite=True
)
write_raw_bids(**shared_kwargs, allow_preload=True)


@pytest.mark.filterwarnings(
warning_str["converting_to_edf"],
warning_str["edfblocks"],
)
@pytest.mark.parametrize("format,ch_type", (("BrainVision", "eeg"), ("EDF", "seeg")))
def test_preload(_bids_validate, tmp_path, format, ch_type):
"""Test writing custom preloaded raw objects."""
bids_root = tmp_path / "bids"
bids_path = _bids_path.copy().update(root=bids_root)
sfreq = 1024.0
info = mne.create_info(["ch1", "ch2"], sfreq, ch_type)
data = np.zeros((2, 100), dtype=np.float32)
data[0, 5] = 1.0 # avoid physical_min == physical_max
raw = mne.io.RawArray(data, info)
raw.orig_format = "single"
raw.info["line_freq"] = 60
write_raw_bids(
raw,
bids_path,
allow_preload=True,
format="BrainVision",
format=format,
verbose=False,
overwrite=True,
)
Expand Down