-
Notifications
You must be signed in to change notification settings - Fork 98
fixes related to doctests #1478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1478 +/- ##
==========================================
- Coverage 96.94% 96.89% -0.05%
==========================================
Files 43 43
Lines 10077 10079 +2
==========================================
- Hits 9769 9766 -3
- Misses 308 313 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sappelhoff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes LGTM
|
CIs unhappy. Pushed a little commit to get things further on my system where it still fails with NumPy-related stuff (a few newlines added by me for readability) Maybe we should use https://github.com/scipy/scipy_doctest to avoid this sort of stuff? Could be worth doing in this PR if it magically fixes things here |
hah. yeah, I made almost exactly those changes already over in #1475. This PR exists because I was trying to split up semantically unrelated changes into different PRs (to make reviewing easier), but then realized that no matter what I do this PR will still have the |
PR Description
event_file_to_annotation_kwargsstrclass (notnp.str_)Merge checklist
Maintainer, please confirm the following before merging.
If applicable: