[ENH, WIP] Add support for BIDS template standard coordinates #973
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #961
Fixes #962
So the issue was that groups wanted to use the standard template coordinate frames but they are currently just mapped to other and then we ask them to change it manually. We have these frames already in the config file so the solution with this PR is to set them to other in the
rawobject returned byread_raw_bidsand then explain to them that MNE does not recognize these coordinate frames so they will be treated asunknownbut you can basically treat it likemriand find the fiducials and make a head->template trans.The channels and coordinate system writing and reading is a bit of a jalopy at the moment with a bunch of things added and it's really hard to follow so I simplified but this will undoubtably break all the tests which I haven't fixed yet.
I'm pushing this now to ask for advice on what's going on with the ieeg example. In the last section, I set a transform, it gets saved in those transformed coordinates, I add back the fiducials and
compute_native_head_tbut it's way off:No idea what's going on there, maybe someone who wrote montage code could help a bit.
Merge checklist
Maintainer, please confirm the following before merging: