Skip to content

Commit 4958296

Browse files
teonbrookspre-commit-ci[bot]autofix-ci[bot]mscheltienne
authored
Improve the contributing guidelines to make an editable install of mne-lsl (#433)
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Mathieu Scheltienne <mathieu.scheltienne@dandelion.science>
1 parent cfb57e4 commit 4958296

2 files changed

Lines changed: 31 additions & 12 deletions

File tree

doc/development/contributing.rst

Lines changed: 29 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,18 @@ You can propose a change; a bugfix, a docstring improvement or a new feature; by
1111
following those steps:
1212

1313
- `Fork the MNE-LSL repository`_ on GitHub
14-
- Clone your fork locally
14+
- Clone your fork locally with submodules:
15+
16+
.. code-block:: console
17+
18+
$ git clone --recurse-submodules https://github.com/yourusername/mne-lsl.git
19+
20+
Or if you already cloned without submodules, initialize them:
21+
22+
.. code-block:: console
23+
24+
$ git submodule update --init --recursive
25+
1526
- (optional, recommended) Create a new branch for your changes
1627
- Make your changes locally and push them to your fork
1728
- `Open a pull request`_ with a clear title and description
@@ -21,24 +32,32 @@ Install in editable mode
2132

2233
To modify MNE-LSL, it is recommended to install it in a separate environment in editable
2334
mode. This way, you can test your changes without having to reinstall the package each
24-
time. To install MNE-LSL in editable mode, run:
35+
time.
36+
37+
.. note::
38+
39+
Installing MNE-LSL in editable mode will build ``liblsl`` using CMake, which
40+
requires:
41+
42+
- A clone of the ``mne-lsl`` repository including the submodules
43+
- CMake (version 3.16 or later)
44+
- A C++ compiler and build tools:
45+
46+
- **Linux**: ``build-essential`` package (``gcc``, ``g++``, ``make``)
47+
- **macOS**: Xcode Command Line Tools (``xcode-select --install``)
48+
- **Windows**: Visual Studio with C++ support or Build Tools for Visual Studio
49+
50+
To install MNE-LSL in editable mode, run:
2551

2652
.. code-block:: console
2753
28-
$ pip install -e .[all]
54+
$ pip install -e ".[all]"
2955
3056
.. note::
3157

3258
The ``[all]`` extra installs all optional dependencies, including those required for
3359
testing and documentation.
3460

35-
.. note::
36-
37-
This command will build ``liblsl`` and will thus require:
38-
39-
- (1) A clone of the ``mne-lsl`` repository including the submodules
40-
- (2) Compilers and build tools installed on your system
41-
4261
Code style
4362
----------
4463

pyproject.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,12 @@ keywords = [
4141
'labstreaminglayer',
4242
'LSL',
4343
'neuroimaging',
44+
'neurophysiology',
4445
'neuroscience',
4546
'python',
4647
'real-time',
4748
]
48-
license = 'BSD-3-Clause'
49-
license-files = ['LICENSE']
49+
license = {file = 'LICENSE'}
5050
maintainers = [
5151
{email = 'mathieu.scheltienne@fcbg.ch', name = 'Mathieu Scheltienne'},
5252
]

0 commit comments

Comments
 (0)