io.read_raw_snirf assumes continous source and detector labels resulting in miss-labeled channels

[Jencke]

When using read_raw_snirf, the implementation currently uses the Source and Detector index as given by sourceIndex and detectorIndex in /nirs/data1/[...]/ instead of using the mapping in /nirs/probe/sourceLabels|detectorLabels.

In cases where there a gaps in the sensor or detector numbers (e.g due to defect optodes), this leads to wrongly numbered channel when reading the snirf files.

Steps to reproduce

use io.read_raw_snirf to read any file that has non-continuous source or channel numbers

Expected results

Source and Channels numbers should reflect gaps in the montage

Actual results

Source and Channel number are continuously numbered irrespective of the montage.

[larsoner]

@Jencke that sounds reasonable, any chance you have or could record / create some small test file that demonstrates this problem? Happy to review a PR to fix this behavior as well!

[Jencke]

Yes, I think I'll find some time to write a PR in the next few weeks.