Skip to content

Commit 00f2791

Browse files
Backport #10041, #10065 (#10068)
* decim is actually used for epochs (#10041) * Don't warn when using decim with ICA.fit() on epochs (#10065) * Don't warn when using decim with ICA.fit() on epochs Follow-up to #10041 * Fix tests Co-authored-by: Alexandre Gramfort <[email protected]>
1 parent 7b5c61c commit 00f2791

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

mne/preprocessing/ica.py

+2-5
Original file line numberDiff line numberDiff line change
@@ -565,9 +565,6 @@ def fit(self, inst, picks=None, start=None, stop=None, decim=None,
565565
decim : int | None
566566
Increment for selecting only each n-th sampling point. If ``None``,
567567
all samples between ``start`` and ``stop`` (inclusive) are used.
568-
569-
.. note:: This parameter only has an effect if ``inst`` is
570-
`~mne.io.Raw` data.
571568
reject, flat : dict | None
572569
Rejection parameters based on peak-to-peak amplitude (PTP)
573570
in the continuous data. Signal periods exceeding the thresholds
@@ -620,8 +617,8 @@ def fit(self, inst, picks=None, start=None, stop=None, decim=None,
620617
if not isinstance(inst, BaseRaw):
621618
ignored_params = [
622619
param_name for param_name, param_val in zip(
623-
('start', 'stop', 'decim', 'reject', 'flat'),
624-
(start, stop, decim, reject, flat)
620+
('start', 'stop', 'reject', 'flat'),
621+
(start, stop, reject, flat)
625622
)
626623
if param_val is not None
627624
]

mne/preprocessing/tests/test_ica.py

-1
Original file line numberDiff line numberDiff line change
@@ -1120,7 +1120,6 @@ def test_fit_methods(method, tmp_path):
11201120
(
11211121
('start', 0),
11221122
('stop', 500),
1123-
('decim', 2),
11241123
('reject', dict(eeg=500e-6)),
11251124
('flat', dict(eeg=1e-6))
11261125
)

0 commit comments

Comments
 (0)