-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add sourcespace to Report #12848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add sourcespace to Report #12848
Conversation
for more information, see https://pre-commit.ci
For Another place it would be nice to add if you're motivated is in Then it would be good to pass some |
Having looked at the many possibilities, I think the best solution would be to add a figure in the This solution has the advantage of being able to also display the EEG sensors projected onto the scalp, as well as displaying only the sources used in for forward computation (as some sources from the original source space may be dropped if too close to the inner skull surface). This will give a global idea of the sensors <-> sources model. mne.viz.plot_alignment(trans=fwd["mri_head_t"], info=fwd["info"], src=fwd["src"], eeg=dict(original=0.2, projected=0.8)) We could also have a clearer view of the source space with an additional plot: |
I like both of those plots! Adding to the |
This reverts commit 7c80b70.
for more information, see https://pre-commit.ci
…into dev-report-src
…into dev-report-src
for more information, see https://pre-commit.ci
…into dev-report-src
|
![]() 1 - Alignment ViewIt seems that the Head & sensor digitization points are not saved in the data_dir = testing.data_path(download=True)
subjects_dir = data_dir / "subjects"
sample_meg_dir = data_dir / "MEG" / "sample"
fwd_fname = sample_meg_dir / "sample_audvis_trunc-meg-eeg-oct-6-fwd.fif"
fwd = mne.read_forward_solution(fwd_fname)
fwd["info"]['dig'] Output:
Since this data is missing, I removed the caption from the alignment image. 2 - Source Space(s) ViewThe view isn't fitting well because the view settings are manually defined here for rendering with a head surface. I see two possible fixes:
However, I'm not 100% sure this view is really needed. Additionally, I'm not sure why there are two front views but no back view in the current view definitions. |
for more information, see https://pre-commit.ci
Good question, a back one would be good. It would also be good to have a frontal that was a little bit from the opposite side as the first one (like the first image in the first row has the head turned a little to the right, would be nice if that row ended with a symmetric one with the head turned a little to the left). If we add that to the first row to get a to a 4 col 2 row layout, then replace the second "straight on front" (currently second row third image) view with one from the back that would give us 7 images (4 first row, 3 second row) which could be good. |
What about this 5x2 layout ? |
I like it! |
…into dev-report-src
for more information, see https://pre-commit.ci
Let me know when I should review! |
I've finally found some time to sort out the last issues. |
Reference issue (if any)
Fixes #12836
What does this implement/fix?
Add a
src
argument to theReport.add_bem
method.Additional information
I'm not sure which strategy to adopt and changes to make to
Report.parse_folder
.The
Report.parse_folder
method automatically adds BEM to theReport
ifReport.subject
is specified. However, several sourcespaces-src.fif
files might be present in the BEM folder and/or folder to parse.