RANGER-4910: addressed review suggesstions; updated to load Polaris service-def during initialization

Author: mneethiraj

agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java

@@ -49,7 +49,7 @@ public class EmbeddedServiceDefsUtil {
     private static final Logger LOG = LoggerFactory.getLogger(EmbeddedServiceDefsUtil.class);
 
     // following servicedef list should be reviewed/updated whenever a new embedded service-def is added
-    public static final String DEFAULT_BOOTSTRAP_SERVICEDEF_LIST        = "tag,gds,hdfs,hbase,hive,kms,knox,storm,yarn,kafka,solr,atlas,nifi,nifi-registry,sqoop,kylin,elasticsearch,presto,trino,ozone,kudu,schema-registry,nestedstructure";
+    public static final String DEFAULT_BOOTSTRAP_SERVICEDEF_LIST        = "tag,gds,hdfs,hbase,hive,kms,knox,storm,yarn,kafka,solr,atlas,nifi,nifi-registry,sqoop,kylin,elasticsearch,presto,trino,ozone,kudu,schema-registry,nestedstructure,polaris";
     public static final String EMBEDDED_SERVICEDEF_TAG_NAME             = "tag";
     public static final String EMBEDDED_SERVICEDEF_GDS_NAME             = "gds";
     public static final String EMBEDDED_SERVICEDEF_HDFS_NAME            = "hdfs";
@@ -75,6 +75,7 @@ public class EmbeddedServiceDefsUtil {
     public static final String EMBEDDED_SERVICEDEF_OZONE_NAME           = "ozone";
     public static final String EMBEDDED_SERVICEDEF_KUDU_NAME            = "kudu";
     public static final String EMBEDDED_SERVICEDEF_NESTEDSTRUCTURE_NAME = "nestedstructure";
+    public static final String EMBEDDED_SERVICEDEF_POLARIS_NAME         = "polaris";
 
     public static final String PROPERTY_CREATE_EMBEDDED_SERVICE_DEFS = "ranger.service.store.create.embedded.service-defs";
     public static final String HDFS_IMPL_CLASS_NAME                  = "org.apache.ranger.services.hdfs.RangerServiceHdfs";
@@ -123,6 +124,7 @@ public class EmbeddedServiceDefsUtil {
     private       RangerServiceDef        ozoneServiceDef;
     private       RangerServiceDef        kuduServiceDef;
     private       RangerServiceDef        nestedStructureServiveDef;
+    private       RangerServiceDef        polarisServiceDef;
     private       RangerServiceDef        tagServiceDef;
     private       RangerServiceDef        gdsServiceDef;
 
@@ -186,6 +188,7 @@ public void init(ServiceStore store) {
             ozoneServiceDef           = getOrCreateServiceDef(store, EMBEDDED_SERVICEDEF_OZONE_NAME);
             kuduServiceDef            = getOrCreateServiceDef(store, EMBEDDED_SERVICEDEF_KUDU_NAME);
             nestedStructureServiveDef = getOrCreateServiceDef(store, EMBEDDED_SERVICEDEF_NESTEDSTRUCTURE_NAME);
+            polarisServiceDef         = getOrCreateServiceDef(store, EMBEDDED_SERVICEDEF_POLARIS_NAME);
 
             gdsServiceDef = getOrCreateServiceDef(store, EMBEDDED_SERVICEDEF_GDS_NAME);
 
@@ -289,6 +292,10 @@ public long getNestedStructureServiceDefId() {
         return getId(nestedStructureServiveDef);
     }
 
+    public long getPolarisServiceDefId() {
+        return getId(polarisServiceDef);
+    }
+
     public long getTagServiceDefId() {
         return getId(tagServiceDef);
     }

agents-common/src/main/resources/service-defs/ranger-servicedef-polaris.json

@@ -168,13 +168,13 @@
     { "itemId": 73, "name": "table-policy-attach",          "label": "Table Policy Attach",          "category": "MANAGE" },
     { "itemId": 74, "name": "table-policy-detach",          "label": "Table Policy Detach",          "category": "MANAGE" },
     { "itemId": 75, "name": "table-properties-read",        "label": "Table Properties Read",        "category": "READ" },
-    { "itemId": 76, "name": "table-properties-write",       "label": "Table Properties Write",       "category": "MANAGE" },
+    { "itemId": 76, "name": "table-properties-write",       "label": "Table Properties Write",       "category": "UPDATE" },
     { "itemId": 77, "name": "table-properties-set",         "label": "Table Properties Set",         "category": "MANAGE" },
     { "itemId": 78, "name": "table-properties-remove",      "label": "Table Properties Remove",      "category": "MANAGE" },
     { "itemId": 79, "name": "table-uuid-assign",            "label": "Table UUID Assign",            "category": "MANAGE" },
     { "itemId": 80, "name": "table-format-version-upgrade", "label": "Table Format Version Upgrade", "category": "MANAGE" },
     { "itemId": 81, "name": "table-schema-add",             "label": "Table Schema Add",             "category": "MANAGE" },
-    { "itemId": 82, "name": "table-schema-set-current",     "label": "Table Schema Set Current",     "category": "READ" },
+    { "itemId": 82, "name": "table-schema-set-current",     "label": "Table Schema Set Current",     "category": "MANAGE" },
     { "itemId": 83, "name": "table-partition-spec-add",     "label": "Table Partition Spec Add",     "category": "MANAGE" },
     { "itemId": 84, "name": "table-partition-specs-remove", "label": "Table Partition Specs Remove", "category": "MANAGE" },
     { "itemId": 85, "name": "table-sort-order-add",         "label": "Table Sort Order Add",         "category": "MANAGE" },
@@ -195,6 +195,6 @@
     { "itemId": 99,  "name": "view-grants-manage",    "label": "View Grants Manage",    "category": "MANAGE" },
     { "itemId": 100, "name": "view-metadata-full",    "label": "View Metadata Full",    "category": "MANAGE" },
     { "itemId": 101, "name": "view-properties-read",  "label": "View Properties Read",  "category": "READ" },
-    { "itemId": 102, "name": "view-properties-write", "label": "View Properties Write", "category": "MANAGE" }
+    { "itemId": 102, "name": "view-properties-write", "label": "View Properties Write", "category": "UPDATE" }
   ]
 }