Merge pull request #153 from mobidata-bw/fix-request-logging

fix request logging

Author: the-infinity

Dockerfile

@@ -30,8 +30,12 @@ CMD [\
 	# > Log verbosity.
 	# > Default: info
 	# > Choices: error, warn, info, alert, debug
+	# > Flow Detail
+	# > Default: 1
+	# > Choices: 0, 1, 2, 3, 4
+	# > Set to 0, because request logging is done by addons.py
 	# https://docs.mitmproxy.org/stable/concepts-options/#available-options
-	"mitmdump -s addons.py --set termlog_verbosity=$LOG_LEVEL" \
+	"mitmdump -s addons.py --set termlog_verbosity=$LOG_LEVEL --set flow_detail=0" \
 ]
 
 # When sending an HTTP request with `Host: localhost`, mitmproxy will respond with 502.

app/app.py

@@ -5,6 +5,7 @@
 """
 
 import json
+import logging
 from importlib import import_module
 from inspect import isclass
 from json import JSONDecodeError
@@ -17,6 +18,8 @@
 from app.base_converter import BaseConverter
 from app.config_helper import ConfigHelper
 
+logger = logging.getLogger('converters.requests')
+
 
 class App:
     json_converters: Dict[str, List[BaseConverter]]
@@ -50,6 +53,9 @@ def request(self, flow: HTTPFlow):
             flow.request.port = 443
 
     def response(self, flow: HTTPFlow):
+        # Log requests
+        logger.info(f'{flow.request.method} {flow.request.url}: HTTP {"-" if flow.response is None else flow.response.status_code}')
+
         # if there is no converter for the requested host, don't do anything
         if flow.request.host not in self.json_converters:
             return