fix: move unique ID generation, error suppression & response validation to generic_call

Author: reinierl

ocpp/charge_point.py

@@ -307,26 +307,13 @@ async def call(self, payload, suppress=True, unique_id=None):
         """
         camel_case_payload = snake_to_camel_case(asdict(payload))
 
-        unique_id = (
-            unique_id if unique_id is not None else str(self._unique_id_generator())
-        )
-
         response = await self.generic_call(
             action=payload.__class__.__name__[:-7],
             payload_json=camel_case_payload,
             suppress=suppress,
             unique_id=unique_id
         )
 
-        if response.message_type_id == MessageType.CallError:
-            LOGGER.warning("Received a CALLError: %s'", response)
-            if suppress:
-                return
-            raise response.to_exception()
-        else:
-            response.action = call.action
-            validate_payload(response, self._ocpp_version)
-
         snake_case_payload = camel_to_snake_case(response.payload)
         # Create the correct Payload instance based on the received payload. If
         # this method is called with a call.BootNotificationPayload, then it
@@ -358,6 +345,10 @@ async def generic_call(self, action, payload_json, suppress=True, unique_id=None
         CallError.
         """
 
+        unique_id = (
+            unique_id if unique_id is not None else str(self._unique_id_generator())
+        )
+
         call = Call(
             unique_id=unique_id,
             action=action,
@@ -371,7 +362,7 @@ async def generic_call(self, action, payload_json, suppress=True, unique_id=None
         async with self._call_lock:
             await self._send(call.to_json())
             try:
-                return await self._get_specific_response(
+                response = await self._get_specific_response(
                     call.unique_id, self._response_timeout
                 )
             except asyncio.TimeoutError:
@@ -380,6 +371,16 @@ async def generic_call(self, action, payload_json, suppress=True, unique_id=None
                     f"{call.to_json()}."
                 )
 
+        if response.message_type_id == MessageType.CallError:
+            LOGGER.warning("Received a CALLError: %s'", response)
+            if suppress:
+                return
+            raise response.to_exception()
+        else:
+            response.action = call.action
+            validate_payload(response, self._ocpp_version)
+            return response
+
     async def _get_specific_response(self, unique_id, timeout):
         """
         Return response with given unique ID or raise an asyncio.TimeoutError.