Tarballer.Do: ignore WalkDir error (for now)

thaJeztah · thaJeztah · commit 3eddce304181 · 2025-04-14T17:05:31.000+02:00
archive.go:1034:19: Error return value of `filepath.WalkDir` is not checked (errcheck)
    		filepath.WalkDir(walkRoot, func(filePath string, f os.DirEntry, err error) error {
    		                ^

Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
diff --git a/archive.go b/archive.go
@@ -1031,7 +1031,8 @@ func (t *Tarballer) Do() {
 		)
 
 		walkRoot := getWalkRoot(t.srcPath, include)
-		filepath.WalkDir(walkRoot, func(filePath string, f os.DirEntry, err error) error {
+		// TODO(thaJeztah): should this error be handled?
+		_ = filepath.WalkDir(walkRoot, func(filePath string, f os.DirEntry, err error) error {
 			if err != nil {
 				log.G(context.TODO()).Errorf("Tar: Can't stat file %s to tar: %s", t.srcPath, err)
 				return nil

Original file line number	Diff line number	Diff line change
`@@ -1031,7 +1031,8 @@ func (t *Tarballer) Do() {`
`1031`	`1031`	`)`
`1032`	`1032`
`1033`	`1033`	`walkRoot := getWalkRoot(t.srcPath, include)`
`1034`		`- filepath.WalkDir(walkRoot, func(filePath string, f os.DirEntry, err error) error {`
	`1034`	`+ // TODO(thaJeztah): should this error be handled?`
	`1035`	`+ _ = filepath.WalkDir(walkRoot, func(filePath string, f os.DirEntry, err error) error {`
`1035`	`1036`	`if err != nil {`
`1036`	`1037`	`log.G(context.TODO()).Errorf("Tar: Can't stat file %s to tar: %s", t.srcPath, err)`
`1037`	`1038`	`return nil`