Skip to content

Commit 6c165c1

Browse files
committed
mountinfo: linux: add a /proc/self/mountinfo fallback
In very specific cases (that we hit in runc), it is possible to be running in a child pid namespace (where the Go process's pid is 1) but still have a host /proc. While this is not a problem with /proc/thread-self (since the process *is* in the host pid namespace), the /proc/self/task/<tid> fallback doesn't work because gettid(2) returns the wrong thread-id for the host pid namespace. There isn't much we can do in this case other than use /proc/self, because the simple workarounds (grep NSpid /proc/self/task/*/status) aren't available in pre-3.17 kernels and any more complicated schemes (such as setting the signal mask to something unique and scanning for it) are unworkable for obvious reasons. Fixes: 12c61a3 ("mountinfo: linux: use /proc/thread-self/mountinfo") Signed-off-by: Aleksa Sarai <[email protected]>
1 parent a4e0878 commit 6c165c1

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

Diff for: mountinfo/mountinfo_linux.go

+8
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,14 @@ func parseMountTable(filter FilterFunc) (_ []*Info, err error) {
156156
// /proc/thread-self/ so we need to manually construct
157157
// /proc/self/task/<tid>/ as a fallback.
158158
f, err = os.Open("/proc/self/task/" + strconv.Itoa(unix.Gettid()) + "/mountinfo")
159+
if os.IsNotExist(err) {
160+
// If /proc/self/task/... failed, it means that our active pid
161+
// namespace doesn't match the pid namespace of the /proc mount. In
162+
// this case we just have to make do with /proc/self, since there
163+
// is no other way of figuring out our tid in a parent pid
164+
// namespace on pre-3.17 kernels.
165+
f, err = os.Open("/proc/self/mountinfo")
166+
}
159167
}
160168
if err != nil {
161169
return nil, err

0 commit comments

Comments
 (0)