refactor(upgrade): make v1.3.0 a noop — authz grants are create-only gates (release/1.3.x)

Mirror of the #263 decision on release/1.3.x. The only authz grants
moca's state machine reads are create-time gates (validator self-del ->
gov MsgDelegate in MsgCreateValidator, SP funding -> gov MsgDeposit in
MsgCreateStorageProvider); nothing consumes them after creation, and a
new creator re-grants before creating, so the grants the moca-iavl bug
dropped need no restoration. Restoring/deleting from a handler is also
consensus-unsafe (enumeration via the store iterator reads the fastnode,
not the tree, and forks on a node whose fastnode is missing a tree-backed
key).

Real fixes are not a handler: cosmos/iavl#1009 in the binary stops the
prove=true panic, and an IAVL fastnode rebuild (state-sync /
fastStorageVersionValue bump) clears the drift.

Removes app/upgrades/v1_3_0_authz_recovery.go and its test.

Author: puneet2019

CHANGELOG.md

@@ -41,7 +41,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
 
 - (proto) [#67](https://github.com/mocachain/moca/pull/67) Publish protos to BSR under moca org
 - (cli) [#243](https://github.com/mocachain/moca/pull/243) Add `mocad snapshots` command tree (list/delete/dump/export/load/restore) for managing local state-sync snapshots
-- (upgrade) [#266](https://github.com/mocachain/moca/pull/266) `v1.3.0` upgrade re-grants the validator self-del → gov (`MsgDelegate`, Generic) authz grant required by `MsgCreateValidator` that the moca-iavl commit-time bug dropped from the merkle tree, keyed off the canonical staking store so it is deterministic on every node. Scope is intentionally minimal (only this required grant); other dropped grants are not reconstructable from on-chain state and owners re-create them
+- (upgrade) [#266](https://github.com/mocachain/moca/pull/266) Add `v1.3.0` upgrade handler (noop `RunMigrations`). The moca-iavl commit-time bug left authz fastnode-vs-tree drift, but the only authz grants moca reads are create-time gates (validator→gov `MsgDelegate` in `MsgCreateValidator`, SP funding→gov `MsgDeposit` in `MsgCreateStorageProvider`) — nothing consumes them after creation, so the dropped grants need no restoration. The `prove=true` panic is fixed by `cosmos/iavl#1009` in the binary; the residual fastnode drift is cleared by an IAVL rebuild (state-sync / `fastStorageVersionValue` bump), not a consensus handler
 
 ### Improvements
 

app/app.go

@@ -1559,19 +1559,23 @@ func (app *Evmos) setupUpgradeHandlers() {
 		return app.mm.RunMigrations(ctx, app.configurator, fromVM)
 	})
 
-	// v1.3.0: re-grant the validator SelfDelAddress -> gov (MsgDelegate) authz
-	// grant that moca's MsgCreateValidator handler requires but that the
-	// moca-iavl commit-time bug dropped from the merkle tree. Keyed off the
-	// canonical staking store so it is deterministic on every node regardless of
-	// per-node fastnode drift; restored as Generic to match the standard
-	// create-validator flow. Other dropped grants are not reconstructable from
-	// on-chain state and owners re-create them; the residual fastnode drift is
-	// fixed by an IAVL rebuild (state-sync / fastStorageVersionValue bump), not
-	// from a consensus handler. The v1.3.0 binary also carries cosmos/iavl#1009.
-	app.UpgradeKeeper.SetUpgradeHandler(
-		upgrades.V1_3_0UpgradeName,
-		upgrades.V1_3_0RestoreValidatorDelegateGrant(app.AuthzKeeper, app.StakingKeeper, app.mm, app.configurator),
-	)
+	// v1.3.0: no state-machine changes. The moca-iavl commit-time bug left authz
+	// fastnode-vs-tree drift, but the only authz grants moca's handlers read are
+	// create-time gates — validator self-del -> gov (MsgDelegate) in
+	// MsgCreateValidator, and SP funding -> gov (MsgDeposit) in
+	// MsgCreateStorageProvider. Nothing consumes them after creation (delegate,
+	// withdraw, unjail, redelegate, edit, deposit top-ups, slashing all skip the
+	// check), and a new creator re-grants right before creating, so the dropped
+	// grants need no restoration. Restoring them is also consensus-unsafe from a
+	// handler (a purge/regrant keyed off the store iterator, which reads the
+	// fastnode not the tree, forks on a node whose fastnode is missing a
+	// tree-backed key). The v1.3.0 binary carries cosmos/iavl#1009 (stops the
+	// prove=true panic on the phantom keys); the residual fastnode drift is
+	// cleared by an IAVL rebuild (state-sync / fastStorageVersionValue bump),
+	// not from this handler.
+	app.UpgradeKeeper.SetUpgradeHandler("v1.3.0", func(ctx context.Context, _ upgradetypes.Plan, fromVM module.VersionMap) (module.VersionMap, error) {
+		return app.mm.RunMigrations(ctx, app.configurator, fromVM)
+	})
 
 	// testnet only upgrade Handlers
 	app.UpgradeKeeper.SetUpgradeHandler(