Skip to content

Commit 708852e

Browse files
committed
chore(proto): drop the orphaned ethermint feemarket protos and generated api code
The in-tree x/feemarket was replaced by cosmos/evm's (cosmos.evm.feemarket.v1 protos, shipped with the module); ethermint.feemarket.v1 has had zero importers since — no gogo types, no keeper, nothing outside api/. The protos only survived because make proto-gen kept regenerating dead pulsar code from the dead sources, and buf push was republishing them to moca's BSR. ethermint/types/v1/account.proto is deliberately untouched: EthAccount is the type URL of every persisted account. Signed-off-by: puneetmahajan <59960662+puneet2019@users.noreply.github.com>
1 parent bc38941 commit 708852e

13 files changed

Lines changed: 1 addition & 7099 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
5959
- (rpc) [#309](https://github.com/mocachain/moca/pull/309) Replace the in-tree JSON-RPC server (`rpc/`, ~16k LOC forked from ethermint/evmos) with `github.com/cosmos/evm/rpc`: the backend, namespaces, and the newHeads/logs/pendingTx subscriptions now come from cosmos/evm (fed by an in-process CometBFT event stream and an ante `PendingTxListener` hook on `*Moca`), and the indexer moves to cosmos/evm's `server/types.TxResult`. Gains `safe`/`finalized` block tags, `eth_getBlockReceipts`, `eth_getHeaderBy*`, `eth_createAccessList`, `debug_traceBlock`, EIP-4844/7702 tx fields, and upstream tracking. New operator knobs (app.toml + flags): `json-rpc.ws-origins`, `json-rpc.enable-profiling`, `json-rpc.allow-insecure-unlock`, `json-rpc.batch-request-limit`, `json-rpc.batch-response-max-size`; the checked-in asset configs also pin `evm.evm-chain-id` per network. A thin `server/websockets.go` shim is retained so `newHeads` emits the canonical CometBFT block hash (completes `cosmos/evm#725`); removable once that lands upstream and we bump.
6060
- (indexer) [#310](https://github.com/mocachain/moca/pull/310) Use `github.com/cosmos/evm/indexer` directly instead of the in-tree functional copy (same `TxResult` proto and key encoding — no reindex needed). The KV-indexer test is retained under `tests/integration/indexer` (mirroring upstream's layout), retargeted at the upstream package, since cosmos/evm publishes no test files in its module — keeping the indexer path covered against moca's forked SDK in CI. The kind e2e now runs validators with `enable-indexer = true` and asserts the tx hash actually lands in `evmindexer.db` (receipt lookups silently fall back to CometBFT `tx_search`, so a green suite alone cannot prove the indexer works).
6161
- (testutil) [#312](https://github.com/mocachain/moca/pull/312) Slim `testutil/`: delete dead helpers (`contract.go`, `integration.go`, `statedb.go`, `CreateEthTx`) and use `cosmos/evm/testutil`'s fork-neutral `NoOpNextFn`/`NewHeader` instead of the in-tree copies. Fork-coupled helpers (key/codec/signing, `testutil/network`, funding) are deliberately kept in-tree — swapping them would change which `ethsecp256k1` type tests exercise.
62+
- (proto) [#PENDING_PR](https://github.com/mocachain/moca/pull/PENDING_PR) Drop the orphaned `ethermint.feemarket.v1` protos and their generated `api/` pulsar code: zero importers since the in-tree `x/feemarket` was replaced by cosmos/evm's (`cosmos.evm.feemarket.v1`), and the dead protos were being republished to moca's BSR. `ethermint/types/v1/account.proto` stays — `EthAccount` is the stored account type.
6263
- (contracts) [#314](https://github.com/mocachain/moca/pull/314) Slim `contracts/` to what moca actually uses (mirroring cosmos/evm's top-level `contracts/` convention): delete the four ERC20 test doubles (`MinterBurnerDecimals`, `Burnable`, `DirectBalanceManipulation`, `MaliciousDelayed`) — dead since the `x/erc20` removal (#221), available upstream where still needed — plus their `.sol` sources, artifacts, and npm manifest. The moca-specific `ERC721NonTransferable` (bucket/object/group NFT facade the storage keeper mints/burns through) stays put, now pinned by a guard test covering its ABI surface, fixed token/hub addresses, and its intentionally bytecode-less (ABI-only) nature. Slither retargets to `solidity/`; the now-subjectless solhint workflow and broken `lint-contracts` Make targets are removed.
6364

6465
### State Machine Breaking

0 commit comments

Comments
 (0)