Skip to content

Commit a8dd359

Browse files
authored
Merge pull request #320 from mocachain/chore/drop-dead-types-utils
chore(types,utils): delete dead ethermint-era helpers
2 parents 9ac2149 + a448eb6 commit a8dd359

11 files changed

Lines changed: 1 addition & 494 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
6161
- (indexer) [#310](https://github.com/mocachain/moca/pull/310) Use `github.com/cosmos/evm/indexer` directly instead of the in-tree functional copy (same `TxResult` proto and key encoding — no reindex needed). The KV-indexer test is retained under `tests/integration/indexer` (mirroring upstream's layout), retargeted at the upstream package, since cosmos/evm publishes no test files in its module — keeping the indexer path covered against moca's forked SDK in CI. The kind e2e now runs validators with `enable-indexer = true` and asserts the tx hash actually lands in `evmindexer.db` (receipt lookups silently fall back to CometBFT `tx_search`, so a green suite alone cannot prove the indexer works).
6262
- (testutil) [#312](https://github.com/mocachain/moca/pull/312) Slim `testutil/`: delete dead helpers (`contract.go`, `integration.go`, `statedb.go`, `CreateEthTx`) and use `cosmos/evm/testutil`'s fork-neutral `NoOpNextFn`/`NewHeader` instead of the in-tree copies. Fork-coupled helpers (key/codec/signing, `testutil/network`, funding) are deliberately kept in-tree — swapping them would change which `ethsecp256k1` type tests exercise.
6363
- (proto) [#316](https://github.com/mocachain/moca/pull/316) Drop the orphaned `ethermint.feemarket.v1` protos and their generated `api/` pulsar code: zero importers since the in-tree `x/feemarket` was replaced by cosmos/evm's (`cosmos.evm.feemarket.v1`), and the dead protos were being republished to moca's BSR. `ethermint/types/v1/account.proto` stays — `EthAccount` is the stored account type.
64+
- (types,utils) [#320](https://github.com/mocachain/moca/pull/320) Delete dead ethermint-era files orphaned by the `rpc/`/`x/evm`/`x/erc20` removals: `types/{block,gasmeter,int,protocol,validation,constant}.go`, `types/openapiutil/`, and `utils/eth/eth.go` — every exported symbol verified unreferenced across the repo and all known external consumers (moca-storage-provider, moca-go-sdk, moca-challenger). Externally-used files (`chain_id.go``ParseChainID` is production code in the storage provider's signer — `grn.go`, `s3util`, `resource`, `common`) are untouched.
6465
- (contracts) [#314](https://github.com/mocachain/moca/pull/314) Slim `contracts/` to what moca actually uses (mirroring cosmos/evm's top-level `contracts/` convention): delete the four ERC20 test doubles (`MinterBurnerDecimals`, `Burnable`, `DirectBalanceManipulation`, `MaliciousDelayed`) — dead since the `x/erc20` removal (#221), available upstream where still needed — plus their `.sol` sources, artifacts, and npm manifest. The moca-specific `ERC721NonTransferable` (bucket/object/group NFT facade the storage keeper mints/burns through) stays put, now pinned by a guard test covering its ABI surface, fixed token/hub addresses, and its intentionally bytecode-less (ABI-only) nature. Slither retargets to `solidity/`; the now-subjectless solhint workflow and broken `lint-contracts` Make targets are removed.
6566

6667
### State Machine Breaking

types/block.go

Lines changed: 0 additions & 37 deletions
This file was deleted.

types/constant.go

Lines changed: 0 additions & 5 deletions
This file was deleted.

types/gasmeter.go

Lines changed: 0 additions & 106 deletions
This file was deleted.

types/int.go

Lines changed: 0 additions & 44 deletions
This file was deleted.

types/openapiutil/apiconsole.go

Lines changed: 0 additions & 31 deletions
This file was deleted.

types/openapiutil/index.tpl

Lines changed: 0 additions & 25 deletions
This file was deleted.

types/protocol.go

Lines changed: 0 additions & 9 deletions
This file was deleted.

types/validation.go

Lines changed: 0 additions & 42 deletions
This file was deleted.

0 commit comments

Comments
 (0)