Skip to content

Commit aef131b

Browse files
committed
fix(e2e): align upgrade test script defaults with release/1.3.x
The three upgrade test scripts defaulted to OLD_VERSION=v1.2.0 and UPGRADE_NAME=v2.0.0 (correct for main, where #221 registered the v2.0.0 handler). On release/1.3.x there is no v2.0.0 handler, so running e.g. `make e2e-fw-test TEST=upgrade_governance` locally without overrides hit: UPGRADE "v2.0.0" NEEDED at height: 49 panic: runtime error: invalid memory address or nil pointer dereference Aligns the local script defaults with the CI workflow defaults set in a5634ae / 18c3477: e2e/kind/tests/test_upgrade_hardfork.sh e2e/kind/tests/test_upgrade_governance.sh e2e/kind/tests/test_upgrade_comprehensive.sh OLD_VERSION v1.2.0 -> v1.2.1 UPGRADE_NAME v2.0.0 -> v1.3.0 (also the example commands in the usage headers) So `make e2e-fw-test TEST=upgrade_governance` on release/1.3.x now exercises the same v1.2.1 -> v1.3.0 path as the CI workflow's default dispatch. Resolves phenix3443's review point 2 on #255.
1 parent 18c3477 commit aef131b

3 files changed

Lines changed: 9 additions & 9 deletions

File tree

e2e/kind/tests/test_upgrade_comprehensive.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
# then runs all verify functions.
1010
#
1111
# Usage:
12-
# OLD_VERSION=v1.2.0 bash tests/test_upgrade_comprehensive.sh
12+
# OLD_VERSION=v1.2.1 bash tests/test_upgrade_comprehensive.sh
1313
# UPGRADE_MODE=hardfork OLD_VERSION=main bash tests/test_upgrade_comprehensive.sh
1414
# TX_ROUNDS=5 bash tests/test_upgrade_comprehensive.sh # 5 rounds of all txs
1515
#
@@ -21,8 +21,8 @@
2121
source "$(dirname "$0")/../framework/framework.sh"
2222
fw_init
2323

24-
OLD_VERSION="${OLD_VERSION:-v1.2.0}"
25-
UPGRADE_NAME="${UPGRADE_NAME:-v2.0.0}"
24+
OLD_VERSION="${OLD_VERSION:-v1.2.1}"
25+
UPGRADE_NAME="${UPGRADE_NAME:-v1.3.0}"
2626
UPGRADE_MODE="${UPGRADE_MODE:-governance}"
2727
TX_ROUNDS="${TX_ROUNDS:-3}"
2828
RELEASE_TAG="${RELEASE_TAG:-}"

e2e/kind/tests/test_upgrade_governance.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@
77
# release tag (e.g., v1.1.2) — not main or the current version.
88
#
99
# Usage:
10-
# OLD_VERSION=v1.2.0 bash tests/test_upgrade_governance.sh
10+
# OLD_VERSION=v1.2.1 bash tests/test_upgrade_governance.sh
1111

1212
source "$(dirname "$0")/../framework/framework.sh"
1313
fw_init
1414

15-
OLD_VERSION="${OLD_VERSION:-v1.2.0}"
16-
UPGRADE_NAME="${UPGRADE_NAME:-v2.0.0}"
15+
OLD_VERSION="${OLD_VERSION:-v1.2.1}"
16+
UPGRADE_NAME="${UPGRADE_NAME:-v1.3.0}"
1717
FEES="200000000000000amoca"
1818

1919
# ── Setup: deploy old version ────────────────────────────────────────────────

e2e/kind/tests/test_upgrade_hardfork.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,14 @@
33
# and validates that state is preserved and the chain continues.
44
#
55
# Usage:
6-
# OLD_VERSION=v1.2.0 bash tests/test_upgrade_hardfork.sh
6+
# OLD_VERSION=v1.2.1 bash tests/test_upgrade_hardfork.sh
77
# OLD_VERSION=main bash tests/test_upgrade_hardfork.sh
88

99
source "$(dirname "$0")/../framework/framework.sh"
1010
fw_init
1111

12-
OLD_VERSION="${OLD_VERSION:-v1.2.0}"
13-
UPGRADE_NAME="${UPGRADE_NAME:-v2.0.0}"
12+
OLD_VERSION="${OLD_VERSION:-v1.2.1}"
13+
UPGRADE_NAME="${UPGRADE_NAME:-v1.3.0}"
1414
FEES="200000000000000amoca"
1515

1616
# ── Setup: deploy old version ────────────────────────────────────────────────

0 commit comments

Comments
 (0)