-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Open
Labels
status: accepting prsMocha can use your help with this one!Mocha can use your help with this one!type: featureenhancement proposalenhancement proposal
Milestone
Description
Feature Request Checklist
- I have read and agree to Mocha's Code of Conduct and Contributing Guidelines
- I have searched for related issues and issues with the
faq
label, but none matched my issue. - I want to provide a PR to resolve this
Overview
Mocha currently depends an older major version of strip-json-comments
:
Line 111 in 5cf2b09
"strip-json-comments": "^3.1.1", |
Suggested Solution
[email protected]
is the latest. It'd be nice to bump to that, so users aren't stuck on a dep that's many major versions behind.
Alternatives
This isn't critical and I don't think we need to do it. But it's nice ecosystem cleanup in general.
I don't know of popular alternatives to strip-json-comments
and haven't looked for them.
Additional Info
strip-json-comments@5
still supports older Node.js than Mocha, so I don't believe we're blocked on that. However, it is an ESM-only package, so this could only happen once Mocha requires Node.js versions that include require(ESM)
(^20.19.0 || >=22.12.0
).
Metadata
Metadata
Assignees
Labels
status: accepting prsMocha can use your help with this one!Mocha can use your help with this one!type: featureenhancement proposalenhancement proposal
Type
Projects
Status
In Progress