Add a built-in require interface without globals#5995
Open
lo1tuma wants to merge 2 commits into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
This adds
requireas a built-in interface so--ui requireandui: requirework consistently from both the CLI and config files.The interface keeps Mocha's DSL helpers off the global object and exposes the function-style APIs through
require("mocha")andimport { ... } from "mocha", including mixed BDD/TDD usage such asitwithsuite.It also fills in the missing require-interface exports, extends the require-interface coverage to exercise the full callable API surface, updates
--list-interfaces, and refreshes the docs for the require interface.