GetVersion is not journaled in journal_test because there are two recorders.

Author: pleroy

journal/player_test.cpp

@@ -84,7 +84,7 @@ TEST_F(PlayerTest, PlayTiny) {
   while (player.Play(count)) {
     ++count;
   }
-  EXPECT_EQ(3, count);
+  EXPECT_EQ(2, count);
 }
 
 TEST_F(PlayerTest, DISABLED_SECULAR_Benchmarks) {

journal/recorder.cpp

@@ -41,7 +41,9 @@ void Recorder::Activate(not_null<Recorder*> const recorder) {
 
   // When the recorder gets activated, pretend that we got a GetVersion call.
   // This will record the version at the beginning of the journal, which is
-  // useful for forensics.
+  // useful for forensics.  Note that this call doesn't register in the tests of
+  // the `journal` project, because there we have two `active_recorder`s, the
+  // one from the test and the one from the DLL.
   char const* build_date;
   char const* version;
   char const* platform;

journal/recorder_test.cpp

@@ -89,24 +89,8 @@ TEST_F(RecorderTest, Recording) {
 
   std::vector<serialization::Method> const methods =
       ReadAll(test_name_ + ".journal.hex");
-  EXPECT_EQ(6, methods.size());
+  EXPECT_EQ(4, methods.size());
   auto it = methods.begin();
-  {
-    EXPECT_TRUE(it->HasExtension(serialization::GetVersion::extension));
-    auto const& extension =
-        it->GetExtension(serialization::GetVersion::extension);
-    EXPECT_FALSE(extension.has_out());
-  }
-  ++it;
-  {
-    EXPECT_TRUE(it->HasExtension(serialization::GetVersion::extension));
-    auto const& extension =
-        it->GetExtension(serialization::GetVersion::extension);
-    EXPECT_TRUE(extension.has_out());
-    EXPECT_EQ(BuildDate, extension.out().build_date());
-    EXPECT_EQ(Version, extension.out().version());
-  }
-  ++it;
   {
     EXPECT_TRUE(it->HasExtension(serialization::DeletePlugin::extension));
     auto const& extension =