[PY-SDK] Remove App._logs (#53365)

GitOrigin-RevId: 378237f54278e9aa39c2077b2c41573efdb86f8f

Author: freddyaboulton

py/modal/app.py

@@ -1579,33 +1579,6 @@ async def get_tags(self, *, client: _Client | None = None) -> dict[str, str]:
         resp = await client.stub.AppGetTags(req)
         return dict(resp.tags)
 
-    async def _logs(self, client: _Client | None = None) -> AsyncGenerator[str, None]:
-        """Stream logs from the app.
-
-        This method is considered private and its interface may change - use at your own risk!
-        """
-        if not self._app_id:
-            raise InvalidError("`app._logs` requires a running/stopped app.")
-
-        client = client or self._client or await _Client.from_env()
-
-        last_log_batch_entry_id: str | None = None
-        while True:
-            request = api_pb2.AppGetLogsRequest(
-                app_id=self._app_id,
-                timeout=55,
-                last_entry_id=last_log_batch_entry_id,
-            )
-            async for log_batch in client.stub.AppGetLogs.unary_stream(request):
-                if log_batch.entry_id:
-                    # log_batch entry_id is empty for fd="server" messages from AppGetLogs
-                    last_log_batch_entry_id = log_batch.entry_id
-                if log_batch.app_done:
-                    return
-                for log in log_batch.items:
-                    if log.data:
-                        yield log.data
-
     @classmethod
     def _get_container_app(cls) -> "_App | None":
         """Returns the `App` running inside a container.
@@ -1621,7 +1594,7 @@ def _reset_container_app(cls):
     async def _get_log_query_data(self) -> _LogQueryData:
         """Get the data needed to query logs for this app."""
         if not self._app_id:
-            raise InvalidError("`app._logs` requires a running/stopped app.")
+            raise InvalidError("`app.logs` requires a running/stopped app.")
         client = self._client or await _Client.from_env()
         filters = LogsFilters()
         return _LogQueryData(client=client, app_id=self._app_id, filters=filters, source_object_id=self._app_id)

py/test/app_test.py

@@ -358,14 +358,14 @@ def test_non_string_app_name():
         App(Image.debian_slim())  # type: ignore
 
 
-def test_app_logs(servicer, client):
+def test_app_logs(servicer, client, set_env_client):
     app = App(include_source=False)
     f = app.function()(dummy)
 
     with app.run(client=client):
         f.remote()
 
-    logs = [data for data in app._logs(client=client)]
+    logs = [entry.message for entry in app.logs.stream()]
     assert logs == ["hello, world (1)\n"]