Skip to content

Commit 0244292

Browse files
committed
avoid unnecessary backup
1 parent a8229ae commit 0244292

File tree

2 files changed

+3
-12
lines changed

2 files changed

+3
-12
lines changed

python/sglang/srt/managers/scheduler_output_processor_mixin.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,9 @@ def process_batch_result_decode(
231231
self.token_to_kv_pool_allocator.free(free_cache_loc_cpu.to("cuda", non_blocking=True))
232232

233233
if self.spec_algorithm.is_eagle():
234-
batch.seq_lens.add_(logits_output.accept_length + 1)
234+
# TODO (timmy): when does this happen?
235+
if batch.seq_lens is not None:
236+
batch.seq_lens.add_(logits_output.accept_length + 1)
235237

236238
accept_length = logits_output.accept_length.tolist()
237239
idx_to_batch = [i for i, length in enumerate(accept_length) for _ in range(length)]

python/sglang/srt/speculative/eagle_worker.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -682,11 +682,6 @@ def forward_draft_extend(
682682
def forward_draft_extend_after_decode(self, batch: ModelWorkerBatch):
683683
assert isinstance(batch.spec_info, EagleDraftInput)
684684
# Backup fields that will be modified in-place
685-
seq_lens_backup = batch.seq_lens.clone()
686-
req_pool_indices_backup = batch.req_pool_indices
687-
accept_length_backup = batch.spec_info.accept_length
688-
return_logprob_backup = batch.return_logprob
689-
690685
input_is_idle = batch.forward_mode.is_idle()
691686

692687
if not input_is_idle and batch.spec_info.verified_id.numel() == 0:
@@ -759,15 +754,9 @@ def forward_draft_extend_after_decode(self, batch: ModelWorkerBatch):
759754

760755
self._detect_nan_if_needed(logits_output)
761756

762-
# Restore backup.
763-
# This is because `seq_lens` can be modified in `prepare_extend_after_decode`
764757
batch.forward_mode = (
765758
ForwardMode.DECODE if not input_is_idle else ForwardMode.IDLE
766759
)
767-
batch.seq_lens = seq_lens_backup
768-
batch.req_pool_indices = req_pool_indices_backup
769-
batch.spec_info.accept_length = accept_length_backup
770-
batch.return_logprob = return_logprob_backup
771760

772761
def capture_for_decode(
773762
self, logits_output: LogitsProcessorOutput, draft_input: EagleDraftInput

0 commit comments

Comments
 (0)