Skip to content

Fix McpServerResource registration #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix McpServerResource registration #411

wants to merge 1 commit into from

Conversation

stephentoub
Copy link
Contributor

  • Add missing filling of ResourceCollection in McpServerOptionsSetup
  • Remove AIFunctionMcpServerXx.ToString overrides; for resources, it was changing behavior undesirably, and for the others it was duplicate code.
  • Fix notification method used for resource list changes.
  • Fix type in WithResources parameter name.

Fixes #408

@stephentoub
Fix McpServerResource registration
14463a6 
- Add missing filling of ResourceCollection in McpServerOptionsSetup
- Remove AIFunctionMcpServerXx.ToString overrides; for resources, it was changing behavior undesirably, and for the others it was duplicate code.
- Fix notification method used for resource list changes.
- Fix type in WithResources parameter name.
@stephentoub stephentoub mentioned this pull request May 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halter73 halter73 Awaiting requested review from halter73

@eiriktsarpalis eiriktsarpalis Awaiting requested review from eiriktsarpalis

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EverythingServer Sample MCP Server Fails to List Resources When Using WithResources...
1 participant
@stephentoub