-
Notifications
You must be signed in to change notification settings - Fork 44
Make real interval clock similar to rational interval clock. #3754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In particular continue example.
henrikt-ma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't say anything regarding the "intention", but I can at least say that this is a backwards incompatible change, and we need to keep in mind the upset feelings around the backwards incompatible changes introduced in MSL 4.1.0. However, if no tool ever implemented what is currently in the specification, I think the risk of upsetting users is negligible.
That said, I personally don't have strong opinions about what is the better semantics to have in the specification. I find it more important to take into consideration how existing tools behave.
henrikt-ma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, better to make a dummy "request changes" while waiting for more input from tool vendors in #3753.
|
Language group: Agreed, incompatible change. |
Co-authored-by: Henrik Tidefelt <[email protected]>
henrikt-ma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Co-authored-by: Henrik Tidefelt <[email protected]>
This is a follow-up to modelica#3754.
As far as I understand the use of previous for interval clocks was intended to be resolved in #2022 - but for some reason the real interval clock part seemed to have been missed. But please verify that this is the intended semantics.
I continued the example to show the similarity with rational interval clock.
Closes #3753