-
Notifications
You must be signed in to change notification settings - Fork 44
Make the grammar more consistent, and explain rewrite based on feedback. #3757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We could also add: |
henrikt-ma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not against rewriting the production rules per se, but I'd like to hear exactly which ambiguity that was reported during the conference?
Co-authored-by: Henrik Tidefelt <[email protected]>
Added above. |
Co-authored-by: Henrik Tidefelt <[email protected]>
|
Let's settle what to do with the example at the next phone meeting! |
|
Language group: Shorten by removing production rules. |
Now done. |
henrikt-ma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only suggesting to omit the See below. The rest is looking good.
Co-authored-by: Henrik Tidefelt <[email protected]>
henrikt-ma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I missed one more thing.
Co-authored-by: Henrik Tidefelt <[email protected]>
henrikt-ma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, then it was the indentation…
Co-authored-by: Henrik Tidefelt <[email protected]>
Co-authored-by: Henrik Tidefelt <[email protected]>
henrikt-ma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
During the conference we got feedback that the grammar is ambiguous.
I understand that the problem is due to trying to make the grammar more logical - but: